Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58315

Allow to customize serverUrl while using rocketSend step

    XMLWordPrintable

Details

    Description

      Today we can only use one RocketChat instance defined in general settings to send notifications. In our team we use multi RocketChat instances so we cannot use this plugin.

      Would be nice if we can define a serverUrl directly in rocketSend step.

      Example :

      rocketSend serverUrl: 'https://myrocket.example.com', channel: 'general', message: 'My message'
      

      Thanks!

      Attachments

        Activity

          thanks for the PR

          mreinhardt Martin Reinhardt added a comment - thanks for the PR
          crazymax Maxime KILT added a comment - https://github.com/jenkinsci/rocketchatnotifier-plugin/pull/37
          crazymax Maxime KILT added a comment -

          Yeah I think I will create a PR

          crazymax Maxime KILT added a comment - Yeah I think I will create a PR

          ok, I like the idea, i think could be easily added. But already struggeling with issues on the latest RocketChat API and will take some time to get it fixed

           

          Nevertheless any PR with this feature is welcome

          mreinhardt Martin Reinhardt added a comment - ok, I like the idea, i think could be easily added. But already struggeling with issues on the latest RocketChat API and will take some time to get it fixed   Nevertheless any PR with this feature is welcome
          crazymax Maxime KILT added a comment - - edited

          I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

          For info, today we use the Slack plugin v2.17 (latest version not working) in a roundabout way for RocketChat:

          slackSend(
              channel: 'jenkins',
              message: 'my message',
              baseUrl: 'https://myrocket.example.com/hooks/',
              teamDomain: 'myrocket',
              token: '0123456789'
          )
          

           

          crazymax Maxime KILT added a comment - - edited I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway? For info, today we use the Slack plugin v2.17 (latest version not working) in a roundabout way for RocketChat: slackSend( channel: 'jenkins' , message: 'my message' , baseUrl: 'https: //myrocket.example.com/hooks/' , teamDomain: 'myrocket' , token: '0123456789' )  

          I see the issue, but how would you pass the login info the step? If we add this feature you also need to pass the login info here..

          mreinhardt Martin Reinhardt added a comment - I see the issue, but how would you pass the login info the step? If we add this feature you also need to pass the login info here..

          People

            crazymax Maxime KILT
            crazymax Maxime KILT
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: