Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58362

CommandLauncher2Test.requireApproval failure due to two copies of SystemCommandLanguage

    • 2.185

      JENKINS-57528 included a bump to the detached script-security which should have been paired with a bump to the detached command-launcher. To reproduce, run

      mvn -f command-launcher-plugin test -Djenkins.version=2.176.1 -Dtest=CommandLauncher2Test\#requireApproval
      

      which passes; now bump its parent to 3.47 and include

      -Djenkins.version=2.176.2-rc28314.ce9ac38e8574 -Pconsume-incrementals
      

      which pulls in this backport by olivergondza and you will get a failure:

      java.lang.AssertionError: expected:<org.jenkinsci.plugins.scriptsecurity.scripts.languages.SystemCommandLanguage@...> but was:<org.jenkinsci.plugins.command_launcher.SystemCommandLanguage@...>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:834)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:144)
      	at hudson.slaves.CommandLauncher2Test$1.evaluate(CommandLauncher2Test.java:119)
      

          [JENKINS-58362] CommandLauncher2Test.requireApproval failure due to two copies of SystemCommandLanguage

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Link New: This issue is caused by JENKINS-57528 [ JENKINS-57528 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins #4099 (Web Link)" [ 23205 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins #4100 (Web Link)" [ 23206 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins-test-harness #146 (Web Link)" [ 23207 ]
          Jesse Glick made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Jesse Glick made changes -
          Released As New: 2.185
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Oleg Nenashev made changes -
          Status Original: Fixed but Unreleased [ 10203 ] New: Resolved [ 5 ]
          Daniel Beck made changes -
          Labels Original: lts-candidate plugin-compat-tester regression New: plugin-compat-tester regression

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: