• Jenkins 2.189

      Between 2.184 and 2.186 it seems to have changed how the /scriptText endpoint returns the data, in 2.186 there are extra newlines at the start of the output which break some of our scripts that use this API to run scripts.

      Running the command

      curl -X POST https://jenkins/scriptText -F 'script=println "hello"'

      produces the following output on 2.184:

      hello 

      but it produces this on on 2.186:

          hello

       

      (On our servers we use crumb issuer and auth but for the sake of simplicity I omitted those from the curl command as I think it is probably irrelevant wrt the issue).

       

          [JENKINS-58548] scriptText URL returns extra newlines

          Istvan Szekeres created issue -
          Daniel Beck made changes -
          Labels New: regression
          Daniel Beck made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]

          Daniel Beck added a comment -

          jvz Could this be from SECURITY-534?

          Daniel Beck added a comment - jvz Could this be from SECURITY-534?

          Matt Sicker added a comment -

          Yeah, that could be. Perhaps we can revert the jelly file and just annotate the base model class?

          Matt Sicker added a comment - Yeah, that could be. Perhaps we can revert the jelly file and just annotate the base model class?
          Matt Sicker made changes -
          Assignee New: Matt Sicker [ jvz ]
          Matt Sicker made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Matt Sicker made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Matt Sicker added a comment -

          https://github.com/jenkinsci/jenkins/pull/4133

          Figured out the problem. Jelly will trim things by default, but a JEXL expression in l:view was introducing untrimmed whitespace for some reason. Refactoring the JEXL expression into vanilla Jelly tags fixed the whitespace issue.

          Matt Sicker added a comment - https://github.com/jenkinsci/jenkins/pull/4133 Figured out the problem. Jelly will trim things by default, but a JEXL expression in l:view was introducing untrimmed whitespace for some reason. Refactoring the JEXL expression into vanilla Jelly tags fixed the whitespace issue.
          Daniel Beck made changes -
          Labels Original: regression New: lts-candidate regression

            jvz Matt Sicker
            pistahh Istvan Szekeres
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: