-
Bug
-
Resolution: Fixed
-
Critical
-
None
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the engineVersion: 1 parameter, I would like this to be treated as the default value to preserve the previous behavior.
I'm happy to put together a patch for this, and likely will soon here.
Here is a patch to change this: https://github.com/jenkinsci/hashicorp-vault-plugin/pull/40
I realize that the newer vault library uses 2 as the default, but I still think preserving the previous behavior is the easiest path forward. If you do not like this solution, I could probably also code something up that allows an admin to set the default version globally in Jenkins so we can do it just on our instance and it doesn't affect anyone else.
- links to
[JENKINS-58970] Backwards compatibility broken with version 2.3.0 for KV1
Brian Saville
created issue -
Brian Saville
made changes -
| Description |
Original:
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the {{engineVersion: 1}} parameter, I would like this to be treated as the default value to preserve the previous behavior. I'm happy to put together a patch for this, and likely will soon here. |
New:
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the {{engineVersion: 1}} parameter, I would like this to be treated as the default value to preserve the previous behavior. -I'm happy to put together a patch for this, and likely will soon here.- Here is a patch to change this: https://github.com/jenkinsci/hashicorp-vault-plugin/pull/40 I realize that the newer vault library uses 2 as the default, but I still think preserving the previous behavior is the easiest path forward. If you do not like this solution, I could probably also code something up that allows an admin to set the default version globally in Jenkins so we can do it just on our instance and it doesn't affect anyone else. |
Brian Saville
made changes -
| Remote Link | New: This issue links to "PR-40 (Web Link)" [ 23408 ] |
Jacob Truman
added a comment - casz I think bksaville is suggesting that you should not have to specify the engine version to maintain existing functionality.
Jacob Truman
added a comment - casz I think bksaville is suggesting that you should not have to specify the engine version to maintain existing functionality. I'd disagree with changing the default, let me come up with a different solution
Brian Saville
added a comment - casz, jacobtruman is absolutely right, I would like to not have to change any existing workflow scripts since many of them are outside of our control. I would argue that the default has already been changed with 2.3.0 and should be set to 1 to match the previous behavior, but I can understand completely if you don't want to do it that way. I would quite happy with a solution that let me set the default version system wide (perhaps in the global configuration options?) so that individual teams/users don't have to update their scripts to have it continue working with v1 engine versions.
Thanks!
Brian Saville
added a comment - casz , jacobtruman is absolutely right, I would like to not have to change any existing workflow scripts since many of them are outside of our control. I would argue that the default has already been changed with 2.3.0 and should be set to 1 to match the previous behavior, but I can understand completely if you don't want to do it that way. I would quite happy with a solution that let me set the default version system wide (perhaps in the global configuration options?) so that individual teams/users don't have to update their scripts to have it continue working with v1 engine versions.
Thanks! Brian Saville
added a comment - You work fast casz, this is exactly what I was looking for, thanks! Any idea on timeline for the next release?
Brian Saville
added a comment - You work fast casz , this is exactly what I was looking for, thanks! Any idea on timeline for the next release? | Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Remote Link | New: This issue links to "hashicorp-vault-plugin PR-42 (Web Link)" [ 23415 ] |
You can already specify the engine version.