-
Bug
-
Resolution: Fixed
-
Critical
-
None
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the engineVersion: 1 parameter, I would like this to be treated as the default value to preserve the previous behavior.
I'm happy to put together a patch for this, and likely will soon here.
Here is a patch to change this: https://github.com/jenkinsci/hashicorp-vault-plugin/pull/40
I realize that the newer vault library uses 2 as the default, but I still think preserving the previous behavior is the easiest path forward. If you do not like this solution, I could probably also code something up that allows an admin to set the default version globally in Jenkins so we can do it just on our instance and it doesn't affect anyone else.
- links to
[JENKINS-58970] Backwards compatibility broken with version 2.3.0 for KV1
Brian Saville
created issue -
Brian Saville
made changes -
| Description |
Original:
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the {{engineVersion: 1}} parameter, I would like this to be treated as the default value to preserve the previous behavior. I'm happy to put together a patch for this, and likely will soon here. |
New:
The latest release is great that it adds support for KV2 secret storage, but it also breaks backwards compatibility. We have many users of Jenkins with their own Jenkinsfiles in various repositories (~300 different references in different places). Instead of requiring the {{engineVersion: 1}} parameter, I would like this to be treated as the default value to preserve the previous behavior. -I'm happy to put together a patch for this, and likely will soon here.- Here is a patch to change this: https://github.com/jenkinsci/hashicorp-vault-plugin/pull/40 I realize that the newer vault library uses 2 as the default, but I still think preserving the previous behavior is the easiest path forward. If you do not like this solution, I could probably also code something up that allows an admin to set the default version globally in Jenkins so we can do it just on our instance and it doesn't affect anyone else. |
Brian Saville
made changes -
| Remote Link | New: This issue links to "PR-40 (Web Link)" [ 23408 ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Remote Link | New: This issue links to "hashicorp-vault-plugin PR-42 (Web Link)" [ 23415 ] |
| Released As | New: https://github.com/jenkinsci/hashicorp-vault-plugin/releases/tag/hashicorp-vault-plugin-2.3.1 | |
| Assignee | Original: Peter Tierno [ ptierno ] | New: Joseph Petersen (old) [ casz ] |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
| Assignee | Original: Joseph Petersen (old) [ casz ] | New: Joseph Petersen [ jetersen ] |