Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58971

GitHub Branch Source Plugin allow api.github.com proxy configuration

      You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

      We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

      This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed:

      GitHubConfiguration.java

       
      And this causes `getRepositoryUrl` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`:

      GitHubSCMSource 

      It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.

          [JENKINS-58971] GitHub Branch Source Plugin allow api.github.com proxy configuration

          Julian Modesto created issue -
          Julian Modesto made changes -
          Description Original: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed:

          [https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105] [
          |https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L478]

          And this causes `getRepositoryUrl` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`.[
          https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L478]

           

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.
          New: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          [This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed|[https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105].|https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105]

           
          And this causes `[getRepositoryUrl|[https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L478]]` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`:
           

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.
          Julian Modesto made changes -
          Description Original: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          [This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed|[https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105].|https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105]

           
          And this causes `[getRepositoryUrl|[https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L478]]` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`:
           

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.
          New: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          [This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed
          |#L105].]
           And this causes `[getRepositoryUrl|#L478]]` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`.

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.
          Julian Modesto made changes -
          Description Original: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          [This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed
          |#L105].]
           And this causes `[getRepositoryUrl|#L478]]` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`.

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.
          New: You can configure a GitHub Enterprise Server for the GitHub Branch Source Plugin.

          We'd like to configure a proxy for api.github.com/github.com that looks like my-github-proxy.com.

          This URL is normalized as a GitHub Enterpise Server, with any trailing slashes removed:


          [GitHubConfiguration.java|https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubConfiguration.java#L105]

           
          And this causes `getRepositoryUrl` to create a URL like `my-github-proxy.comOrganization/Repo` instead of `my-github-proxy.com/Organization/Repo`:


          [GitHubSCMSource|https://github.com/jenkinsci/github-branch-source-plugin/blob/d2f00f66a471763b3cfefb54897dc8c03ad2e4cf/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L478

          It would be great if we could either not normalize URLs like this, or allow for specifying both a checkout url and an api url.

            Unassigned Unassigned
            julianvmodesto Julian Modesto
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: