-
Bug
-
Resolution: Unresolved
-
Minor
-
None
Since commit 853603cccd4434b116ef9b8e094c3f5b815aa75a, we set GIT_LFS_SKIP_SMUDGE=1 to improve performance, and require users to add the "Git LFS pull after checkout" additional behaviour to resolve pointers.
This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work.
Since then, a lot has improved:
Clone performance through the smudge filter has improved since https://github.com/git-lfs/git-lfs/pull/2511.
Backends should support the git-lfs-authenticate dance as described in https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh, which retrieves a temporary authorization token to do the clone over https.
I propose to just do a git clone without setting GIT_LFS_SKIP_SMUDGE=1. Most systems should have done a git lfs install before, so they will resolve the lfs pointers during a clone. We can keep the "Git LFS pull after checkout" additional behaviour, for systems that don't have setup global smudge filters via git lfs install.
- is related to
-
JENKINS-62587 Log git version before cloning via CLI
-
- Closed
-
- relates to
-
JENKINS-47531 git-lfs: allow specifying separate credentials
-
- Closed
-
-
JENKINS-56569 Prevent automatic pulling of lfs files if no GitLFSPull option is set
-
- Open
-
[JENKINS-59139] don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+
Assignee | Original: Mark Waite [ markewaite ] |
Labels | New: newbie-friendly |
Summary | Original: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning | New: don't set GIT_LFS_SKIP_SMUDGE=1 anymore while cloning with git 2.15+ |
Link | New: This issue relates to JENKINS-56569 [ JENKINS-56569 ] |
Link |
New:
This issue relates to |
Description |
Original:
Since [https://github.com/jenkinsci/git-client-plugin/commit/853603cccd4434b116ef9b8e094c3f5b815aa75a,] we set GIT_LFS_SKIP_SMUDGE=1 to improve performance, and require users to add the "Git LFS pull after checkout" "Additional behaviour" to resolve pointers. This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work. Since then, a lot has improved: Clone Performance through the smudge filter has improved since [https://github.com/git-lfs/git-lfs/pull/2511.|https://github.com/git-lfs/git-lfs/pull/2511] Backends should support the `git-lfs-authenticate` dance as described in [https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh], which retrieves a temporary authorization token to do the clone over https. I propose to just do a git clone without setting `GIT_LFS_SKIP_SMUDGE=1`. Most systems should have done a `git lfs install` before, so they will resolve the lfs pointers during a clone. We can keep the "Git LFS pull after checkout" "Additional behaviour", for systems that don't have setup global smudge filters via `git lfs install`. |
New:
Since commit [853603cccd4434b116ef9b8e094c3f5b815aa75a|https://github.com/jenkinsci/git-client-plugin/commit/853603cccd4434b116ef9b8e094c3f5b815aa75a], we set {{GIT_LFS_SKIP_SMUDGE=1}} to improve performance, and require users to add the "Git LFS pull after checkout" additional behaviour to resolve pointers. This was mostly done because git clone performance was pretty bad with the smudge filter enabled, and in some configurations, (ssh clone URLs), git lfs pull didn't work. Since then, a lot has improved: Clone performance through the smudge filter has improved since [https://github.com/git-lfs/git-lfs/pull/2511]. Backends should support the {{git-lfs-authenticate}} dance as described in [https://github.com/git-lfs/git-lfs/blob/master/docs/api/authentication.md#ssh], which retrieves a temporary authorization token to do the clone over https. I propose to just do a git clone without setting {{GIT_LFS_SKIP_SMUDGE=1}}. Most systems should have done a {{git lfs install}} before, so they will resolve the lfs pointers during a clone. We can keep the "Git LFS pull after checkout" additional behaviour, for systems that don't have setup global smudge filters via {{git lfs install}}. |
Link |
New:
This issue is related to |
Labels | Original: newbie-friendly |