Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59600

Promotion logs not accessible anymore after Jenkins upgrade

    XMLWordPrintable

Details

    • Promoted Builds 3.4

    Description

      After update from 2.73.3 to 2.190.1, we can't access promotion logs anymore. While the link looks correct, Jenkins now shows the log of the promoted build instead of the promotion log.

      Attachments

        Issue Links

          Activity

            jprice904 Jake Price added a comment -

            Facing the same issue as well which has made it difficult to troubleshoot promotion failures.

            jprice904 Jake Price added a comment - Facing the same issue as well which has made it difficult to troubleshoot promotion failures.
            danielbeck Daniel Beck added a comment -

            This is probably either a security fix in 2.138.4 or 2.176.2. The Jenkins system log should include a relevant message.

            danielbeck Daniel Beck added a comment - This is probably either a security fix in 2.138.4 or 2.176.2. The Jenkins system log should include a relevant message.

            This one, maybe?

            Use of toString() on hudson.util.Secret from org.apache.commons.jelly.expression.ExpressionSupport.evaluateAsString(ExpressionSupport.java:53). Prefer getPlainText() or getEncryptedValue() depending your needs. see https://jenkins.io/redirect/hudson.util.Secret/ 
            dhs Dirk Heinrichs added a comment - This one, maybe? Use of toString() on hudson.util.Secret from org.apache.commons.jelly.expression.ExpressionSupport.evaluateAsString(ExpressionSupport.java:53). Prefer getPlainText() or getEncryptedValue() depending your needs. see https: //jenkins.io/redirect/hudson.util.Secret/
            danielbeck Daniel Beck added a comment - https://jenkins.io/doc/upgrade-guide/2.138/#SECURITY-595 or https://jenkins.io/doc/upgrade-guide/2.176/#SECURITY-534 would be my guess.

            Neither warnings mentioned under above links show up in the log here when I try to view a promotion log.

            dhs Dirk Heinrichs added a comment - Neither warnings mentioned under above links show up in the log here when I try to view a promotion log.
            danielbeck Daniel Beck added a comment -

            Interesting. This might be related to a change in Jenkins 2.138.2 that should not have any side effects. Unfortunately these versions are so old that it's no longer straightforward to set up a new Jenkins instance with all the required dependencies from scratch.

            Ideally someone here can confirm it works in 2.138.1 (or 2.146) and does no longer work in 2.138.2 (or 2.147).

            danielbeck Daniel Beck added a comment - Interesting. This might be related to a change in Jenkins 2.138.2 that should not have any side effects. Unfortunately these versions are so old that it's no longer straightforward to set up a new Jenkins instance with all the required dependencies from scratch. Ideally someone here can confirm it works in 2.138.1 (or 2.146) and does no longer work in 2.138.2 (or 2.147).
            danielbeck Daniel Beck added a comment -

            Confirmed broke in 2.138.2 (which is interestingly older than the minimum version for current releases of 2.138.4, so manual or automated testing before release should have caught this).

            danielbeck Daniel Beck added a comment - Confirmed broke in 2.138.2 (which is interestingly older than the minimum version for current releases of 2.138.4, so manual or automated testing before release should have caught this).
            jprice904 Jake Price added a comment - - edited

            For what it's worth my upgrade path to 2.190.1 looked like this:

            2.164.3 (promotion logs working) -> 2.190.1 (broken)

            I had to roll back and rolled back to 2.176.1 where it is once again working.  2.176.3 gave me LDAP plugin issues so that is why 2.176.1 was chosen.

            jprice904 Jake Price added a comment - - edited For what it's worth my upgrade path to 2.190.1 looked like this: 2.164.3 (promotion logs working) -> 2.190.1 (broken) I had to roll back and rolled back to 2.176.1 where it is once again working.  2.176.3 gave me LDAP plugin issues so that is why 2.176.1 was chosen.
            danielbeck Daniel Beck added a comment - PR with fix up at https://github.com/jenkinsci/promoted-builds-plugin/pull/140
            danielbeck Daniel Beck added a comment -

            2.164.3 (promotion logs working) -> 2.190.1 (broken)

            Based on Filipe's analysis in a comment to JENKINS-58337 that's probably only because you're changing versions of both core and plugins here. The problem was introduced in Jenkins 2.138.2/2.147 and integrated into the plugin in 3.3.

            danielbeck Daniel Beck added a comment - 2.164.3 (promotion logs working) -> 2.190.1 (broken) Based on Filipe's analysis in a comment to JENKINS-58337 that's probably only because you're changing versions of both core and plugins here. The problem was introduced in Jenkins 2.138.2/2.147 and integrated into the plugin in 3.3.
            oleg_nenashev Oleg Nenashev added a comment - Thanks to danielbeck , the fix was released in 3.4:  https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/promoted-builds-3.4
            jdege Jeff Dege added a comment -

            This is a show-stopper for us,

            I'm trying to set up promotions on a job, and I'm getting this every time I try to re-execute a promotion.

            Any ideas when it will be fixed?

            Or what I need to roll back, and how far, to get this working?

             

            jdege Jeff Dege added a comment - This is a show-stopper for us, I'm trying to set up promotions on a job, and I'm getting this every time I try to re-execute a promotion. Any ideas when it will be fixed? Or what I need to roll back, and how far, to get this working?  

            People

              Unassigned Unassigned
              dhs Dirk Heinrichs
              Votes:
              5 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: