Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59665

Rework sorting for Uninstall columns of Installed in Plugin Manager

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.205

      Description

      open /pluginManager/installed (Jenkins 2.198)

      Have:

      1. a couple of plugins with dependencies (enabled)
      2. a couple of plugins (disabled)
      3. a couple of plugins that have never been upgraded
      4. a couple of plugins which have been upgraded

      Actual results

      I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).

      Expected results

      Sorting by Uninstall should sort into two sets:
      1. Uninstall button enabled
      2. Uninstall button disabled

        Attachments

          Issue Links

            Activity

            jsoref Josh Soref created issue -
            jsoref Josh Soref made changes -
            Field Original Value New Value
            Description open /pluginManager/installed

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Enabled should sort into three sets:
             # Enabled (checkbox checked)

             # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)

             # Disabled (checkbox unchecked)

            h5. Sorting by Uninstall should sort into: two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            open /pluginManager/installed (Jenkins 2.198)

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Enabled should sort into three sets:
             # Enabled (checkbox checked)

             # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)

             # Disabled (checkbox unchecked)

            h5. Sorting by Uninstall should sort into: two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            danielbeck Daniel Beck made changes -
            Labels newbie-friendly
            jsoref Josh Soref made changes -
            Description open /pluginManager/installed (Jenkins 2.198)

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Enabled should sort into three sets:
             # Enabled (checkbox checked)

             # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)

             # Disabled (checkbox unchecked)

            h5. Sorting by Uninstall should sort into: two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            open /pluginManager/installed (Jenkins 2.198)

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Enabled should sort into three sets:
             # Enabled (checkbox checked)
             # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)
             # Disabled (checkbox unchecked)

            h5. Sorting by Uninstall should sort into two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            mhampp Manuel Hampp made changes -
            Assignee Manuel Hampp [ mhampp ]
            mhampp Manuel Hampp made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            mhampp Manuel Hampp made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            mhampp Manuel Hampp added a comment -

            Hi,

            I fixed the sorting for the uninstall column. The enabled column already seems to work fine.

            BG

            Manuel

            pull request: https://github.com/jenkinsci/jenkins/pull/4298

            Show
            mhampp Manuel Hampp added a comment - Hi, I fixed the sorting for the uninstall column. The enabled column already seems to work fine. BG Manuel pull request: https://github.com/jenkinsci/jenkins/pull/4298
            mhampp Manuel Hampp made changes -
            Assignee Manuel Hampp [ mhampp ] Josh Soref [ jsoref ]
            mhampp Manuel Hampp made changes -
            Assignee Josh Soref [ jsoref ] Manuel Hampp [ mhampp ]
            Hide
            danielbeck Daniel Beck added a comment -

            At least on Jenkins 2.190.1, the "Enabled" column does not behave.

            Show
            danielbeck Daniel Beck added a comment - At least on Jenkins 2.190.1, the "Enabled" column does not behave.
            danielbeck Daniel Beck made changes -
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-60117 [ JENKINS-60117 ]
            oleg_nenashev Oleg Nenashev made changes -
            Summary Rework sorting for the Enabled and Uninstall columns of Installed in Plugin Manager Rework sorting for Uninstall columns of Installed in Plugin Manager
            oleg_nenashev Oleg Nenashev made changes -
            Description open /pluginManager/installed (Jenkins 2.198)

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Enabled should sort into three sets:
             # Enabled (checkbox checked)
             # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)
             # Disabled (checkbox unchecked)

            h5. Sorting by Uninstall should sort into two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            open /pluginManager/installed (Jenkins 2.198)

            Have:
             # a couple of plugins with dependencies (enabled)
             # a couple of plugins (disabled)
             # a couple of plugins that have never been upgraded
             # a couple of plugins which have been upgraded

            h3. Actual results

            I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
            h3. Expected results
            h5. Sorting by Uninstall should sort into two sets:
             # Uninstall button enabled
             # Uninstall button disabled
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            "Enabled" column was detached to JENKINS-60117

            Show
            oleg_nenashev Oleg Nenashev added a comment - "Enabled" column was detached to JENKINS-60117
            oleg_nenashev Oleg Nenashev made changes -
            Released As Jenkins 2.105
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            oleg_nenashev Oleg Nenashev made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels newbie-friendly lts-candidate newbie-friendly
            olivergondza Oliver Gondža made changes -
            Released As Jenkins 2.105 Jenkins 2.205
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate newbie-friendly 2.204.1-fixed newbie-friendly

              People

              Assignee:
              mhampp Manuel Hampp
              Reporter:
              jsoref Josh Soref
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: