• Type: Improvement
• Resolution: Done
• Priority: Major
• Component/s: urltrigger-plugin
• Labels:

  None

[JENKINS-59831] update JsonPath from 0.5.5 to 2.4.0

Kemal Soysal created issue - 2019-10-17 20:24

Kemal Soysal made changes - 2019-10-17 21:06

Description

Original: I have a git repository where I would want to see changes on branches by certain criteria on their names. The JsonPath 0.5.5 does not work with regular expressions well. The JsonPath 2.4.0 does offer richer regular expression syntax allowing me to discover changes on revisions for multiple branches of interest.

New: I have a git repository where I would want to see changes on branches by certain criteria on their names. The JsonPath 0.5.5 does not work with regular expressions well. The JsonPath 2.4.0 does offer richer regular expression syntax allowing me to discover changes on revisions for multiple branches of interest. For the test file oldJsonContent.json you can check on [https://jsonpath.herokuapp.com|https://jsonpath.herokuapp.com/]  $..[?(@.category =~ /refer.+/)].title should deliver ["Title A"] and the test file newJsonContent.json ["Sayings of the Century"]

Collapse comment: Kemal Soysal added a comment - 2019-10-17 23:03

Kemal Soysal added a comment - 2019-10-17 23:03

Pullrequest https://github.com/jenkinsci/urltrigger-plugin/pull/25 is implementing the desired behavior.

Expand comment: Kemal Soysal added a comment - 2019-10-17 23:03

Kemal Soysal added a comment - 2019-10-17 23:03 Pullrequest https://github.com/jenkinsci/urltrigger-plugin/pull/25  is implementing the desired behavior.

Kemal Soysal made changes - 2019-10-18 15:16

Assignee

Original: Gregory Boissinot [ gbois ]

New: Kemal Soysal [ kemalsoysal ]

Kemal Soysal made changes - 2019-10-18 15:17

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Kemal Soysal made changes - 2019-10-18 15:32

Status

Original: In Progress [ 3 ]

New: Open [ 1 ]

Kemal Soysal made changes - 2019-10-18 15:32

Assignee

Original: Kemal Soysal [ kemalsoysal ]

New: Gregory Boissinot [ gbois ]

Kemal Soysal made changes - 2019-10-18 15:48

Assignee

Original: Gregory Boissinot [ gbois ]

New: Tony Noble [ stealthdj ]

Tony Noble made changes - 2019-10-21 09:05

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Collapse comment: Tony Noble added a comment - 2019-10-21 09:08

Tony Noble added a comment - 2019-10-21 09:08

Hi Kemal,

Thanks for the contribution.  I'll take a more in-depth look shortly, though looks generally good.  My one concern is that we now don't differentiate between a jsonPath being present and empty, and a jsonPath not being present at all.  The existing solution is probably not ideal, but I don't feel we should lose detail that was previously available (however badly presented)

 

Expand comment: Tony Noble added a comment - 2019-10-21 09:08

Tony Noble added a comment - 2019-10-21 09:08 Hi Kemal, Thanks for the contribution.  I'll take a more in-depth look shortly, though looks generally good.  My one concern is that we now don't differentiate between a jsonPath being present and empty, and a jsonPath not being present at all.  The existing solution is probably not ideal, but I don't feel we should lose detail that was previously available (however badly presented)  

Load more newer events