Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60217

When condition for Changeset with comparator

XMLWordPrintable

    • 1.5.0

      https://issues.jenkins-ci.org/browse/JENKINS-48523  added support to the tag when condition with the comparator. 

      At the moment, the changeset when condition does support GLOB, but no REGEXP patterns. Let's standardize the changeset condition format as done with the tag condition.

      when {
    changeset "**/*.java"
}
when {
    changeset pattern: "**/*.java", comparator: "GLOB"
} 
when {
    changeset pattern: ".*\\.java", comparator: "REGEXP"
}

          [JENKINS-60217] When condition for Changeset with comparator

          Victor Martinez created issue -
          Victor Martinez made changes -
          Description Original: https://issues.jenkins-ci.org/browse/JENKINS-48523  added support to the tag when condition with the comparator. 

          At the moment, the branch when condition does support GLOB, but no REGEXP patterns. Let's standardize the branch condition format as done with the tag condition.
          {code:java}

          when {
              branch "release-*"
          }
          when {
              branch pattern: "release-*", comparator: "GLOB"
          }
          when {
              branch pattern: "release-\\d+", comparator: "REGEXP"
          } {code}           		New: https://issues.jenkins-ci.org/browse/JENKINS-48523  added support to the tag when condition with the comparator. 

          At the moment, the changeset when condition does support GLOB, but no REGEXP patterns. Let's standardize the changeset condition format as done with the tag condition.
          {code:java}
          when {
              changeset "**/*.java"
          }
          when {
              changeset pattern: "**/*.java", comparator: "GLOB"
          }
          when {
              changeset pattern: ".*\\.java", comparator: "REGEXP"
          } {code}
          Victor Martinez made changes -
          Released As Original: 1.4.0

          Jonathan Delizy added a comment -

          The v1.5.0 of pipeline-model-definition-plugin is released and include implementation of this ticket but documentation has not been updated.
          This cause confusion for people like me who update the plugin, have failed builds caused by this breaking change and found contradictory information between the error message and current documentation.

          I have previously seen alerts in the Update Center about possible incompatible configuration before updating some plugins. It could have been a good idea to use the same thing to alert user of this breaking change before they update.

          Jonathan Delizy added a comment - The v1.5.0 of pipeline-model-definition-plugin is released and include implementation of this ticket but documentation has not been updated. This cause confusion for people like me who update the plugin, have failed builds caused by this breaking change and found contradictory information between the error message and current documentation. I have previously seen alerts in the Update Center about possible incompatible configuration before updating some plugins. It could have been a good idea to use the same thing to alert user of this breaking change before they update.
          Victor Martinez made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Victor Martinez made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 24106 ]
          Victor Martinez made changes -
          Remote Link New: This issue links to "PR-DOCS (Web Link)" [ 24107 ]

          Victor Martinez added a comment -

          jonathand131, may I ask you to raise another ticket with the details of the error?

           

          For the docs:
          - https://github.com/jenkins-infra/jenkins.io/pull/2664

          Victor Martinez added a comment - jonathand131 , may I ask you to raise another ticket with the details of the error?   For the docs: -  https://github.com/jenkins-infra/jenkins.io/pull/2664
          Victor Martinez made changes -
          Released As New: 1.5.0

          Jonathan Delizy added a comment -

          v2v:
          Thanks for the update of the documentation.
          It is not yet visible on https://jenkins.io/doc/book/pipeline/syntax/#when but I think it is a matter of time since the PR is merged.

          About the error, it is that the syntax changeset glob: "*/.java" is not supported anymore, glob must be replaced by pattern.
          This syntax was in the example on the documentation page.
          It is the consequence of this ticket. I suppose it is intentional so I don't think I need to open a bug for that. Should I ?

          Jonathan Delizy added a comment - v2v : Thanks for the update of the documentation. It is not yet visible on https://jenkins.io/doc/book/pipeline/syntax/#when but I think it is a matter of time since the PR is merged. About the error, it is that the syntax changeset glob: "* / .java" is not supported anymore, glob must be replaced by pattern . This syntax was in the example on the documentation page. It is the consequence of this ticket. I suppose it is intentional so I don't think I need to open a bug for that. Should I ?

            v2v Victor Martinez
            v2v Victor Martinez
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: