Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60420

Skip notifications plugin fails after 1.0.4 release

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • skip-notifications-trait-plugin
    • None
    • Install Gihub and Bitbucket on the same Jenkins instance
    • 1.0.5

      If you have Github and Bitbucket installed as plugins and you use Skip Notifications Trait you will get this error after `1.0.4` release:

       

      ERROR: Found multiple extensions which provide method skipNotificationsTrait with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, org.jenkinsci.plugins.github.notifications.SkipNotificationsTrait]]

      This problem was introduced by this PR:

      https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5

          [JENKINS-60420] Skip notifications plugin fails after 1.0.4 release

          Michel Zanini created issue -
          Michel Zanini made changes -
          Description Original: If you have Github and Bitbucket installed as plugins and you use Skip Notifications Trait you will get this error after `1.0.4` release:

           
          {code:java}
          ERROR: Found multiple extensions which provide method skipNotificationsTrait with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, org.jenkinsci.plugins.github.notifications.SkipNotificationsTrait]]
          {code}           		New: If you have Github and Bitbucket installed as plugins and you use Skip Notifications Trait you will get this error after `1.0.4` release:

           
          {code:java}
          ERROR: Found multiple extensions which provide method skipNotificationsTrait with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, org.jenkinsci.plugins.github.notifications.SkipNotificationsTrait]]
          {code}
          This problem was introduced by this PR:

          [https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5]

          Alex Dubrouski added a comment - - edited

          Good morning,

          Thanks a lot for reporting.
          I have couple of options:
          1. Roll back the changes by v2v and let him create a separate plugin for GitHub Branch Source
          2. I have a local snapshot which has classes and method names renamed, tried to create GitHub/BitBucket organization and it was successful

          Which way will be preferable for you michelzanini?

          Alex Dubrouski added a comment - - edited Good morning, Thanks a lot for reporting. I have couple of options: 1. Roll back the changes by v2v and let him create a separate plugin for GitHub Branch Source 2. I have a local snapshot which has classes and method names renamed, tried to create GitHub/BitBucket organization and it was successful Which way will be preferable for you michelzanini ?

          Victor Martinez added a comment -

           

          For some reason when I created that PR I though the annotation https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5/files#diff-23463add934ca349639c9de7d8e27777R66 was intended to help with this. Good to know for the future.

           

          Sorry about that, I'd say option 2) could be more beneficial. 

           

          Thanks

          Victor Martinez added a comment -   For some reason when I created that PR I though the annotation  https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5/files#diff-23463add934ca349639c9de7d8e27777R66  was intended to help with this. Good to know for the future.   Sorry about that, I'd say option 2) could be more beneficial.    Thanks

          Alex Dubrouski added a comment -

          Thanks for your feedback Victor, let's wait for Michel and then I will do changes and release.

          Alex Dubrouski added a comment - Thanks for your feedback Victor, let's wait for Michel and then I will do changes and release.

          Michel Zanini added a comment -

          I agree. Option 2 should be ok.

          Michel Zanini added a comment - I agree. Option 2 should be ok.

          Alex Dubrouski added a comment -

          Ok, I tested locally and haven't seen any issues creating BB/GH orgs. I will release soon, could you please re-test?

          Alex Dubrouski added a comment - Ok, I tested locally and haven't seen any issues creating BB/GH orgs. I will release soon, could you please re-test?

          Alex Dubrouski added a comment -

          Added you both to PR.

          Alex Dubrouski added a comment - Added you both to PR.

          Alex Dubrouski added a comment -

          New release is published, please re-check.

          Alex Dubrouski added a comment - New release is published, please re-check.

          Michel Zanini added a comment -

          Seems to work, I updated and the error is not showing up anymore. Thanks.

          Michel Zanini added a comment - Seems to work, I updated and the error is not showing up anymore. Thanks.

            alex_dubrouski Alex Dubrouski
            michelzanini Michel Zanini
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: