Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61465

Make Functions#checkAnyPermission work on objects that aren't AccessControlled

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • 2.226

      Functions#checkAnyPermission doesn't have an overload for an Object first arg (rather than AccessControlled.

      As explained in https://github.com/jenkinsci/jenkins/blob/a79101ce5440f2cff160dde791e923ce2548cfbe/core/src/main/java/hudson/Functions.java#L838-L842 this is a problem:

      Multiple-permission checks won't work on views belonging to objects that aren't AccessControlled. Even more annoying given that all use cases for this feature at the moment would check on app / the Jenkins singleton anyway.

          [JENKINS-61465] Make Functions#checkAnyPermission work on objects that aren't AccessControlled

          Daniel Beck created issue -
          Daniel Beck made changes -
          Assignee New: Daniel Beck [ danielbeck ]
          Daniel Beck made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Daniel Beck made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Daniel Beck made changes -
          Remote Link New: This issue links to "PR 4573 (Web Link)" [ 24733 ]
          Daniel Beck made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]
          Daniel Beck made changes -
          Summary Original: Functions#checkAnyPermission only works on AccessControlled New: Make Functions#checkAnyPermission work on objects that aren't AccessControlled
          Daniel Beck made changes -
          Released As New: 2.226
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 2.222.2-fixed

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: