Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61478

"Apply" (and similar) banners look really bad with larger header bar

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Released As:
      Jenkins 2.230

      Description

      Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

      With the 2.222 design update, that is no longer the case. They look broken now (not merely ugly ).

        Attachments

          Issue Links

            Activity

            danielbeck Daniel Beck created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Attachment Screenshot 2020-03-14 at 00.06.15.png [ 50673 ]
            Hide
            danielbeck Daniel Beck added a comment -
            Show
            danielbeck Daniel Beck added a comment - FYI Félix Queiruga Balado
            danielbeck Daniel Beck made changes -
            Labels regression regression ux
            danielbeck Daniel Beck made changes -
            Description Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

            With the 2.222 design update, that is no longer the case. They look broken now.
            Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

            With the 2.222 design update, that is no longer the case. They look broken now (not merely ugly :D).
            Hide
            fqueiruga Félix Queiruga Balado added a comment - - edited

            It would make sense to revisit the banner. Can someone add it to the https://issues.jenkins-ci.org/browse/JENKINS-60919 epic and mark this as an improvement? We can triage it on the SIG meeting.

            Edit: nevermind, I did that

            Show
            fqueiruga Félix Queiruga Balado added a comment - - edited It would make sense to revisit the banner. Can someone add it to the  https://issues.jenkins-ci.org/browse/JENKINS-60919  epic and mark this as an improvement? We can triage it on the SIG meeting. Edit:  nevermind, I did that
            fqueiruga Félix Queiruga Balado made changes -
            Epic Link JENKINS-60919 [ 204316 ]
            fqueiruga Félix Queiruga Balado made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            Hide
            danielbeck Daniel Beck added a comment -

            an improvement

            So you're saying the banner doesn't look any more broken now than it did in 2.221 before the UI refresh?

            Show
            danielbeck Daniel Beck added a comment - an improvement So you're saying the banner doesn't look any more broken now than it did in 2.221 before the UI refresh?
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            I'm saying I don't consider it a bug. But it's OK, I'll mark it back as a bug and we can talk about it on the next SIG meeting, maybe we could even get some designs going.

            Show
            fqueiruga Félix Queiruga Balado added a comment - I'm saying I don't consider it a bug. But it's OK, I'll mark it back as a bug and we can talk about it on the next SIG meeting, maybe we could even get some designs going.
            fqueiruga Félix Queiruga Balado made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            Hide
            romenrg Romen Rodriguez-Gil added a comment - - edited

            I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement.

            Are you OK if I take the ticket and play with it a bit?

            EDIT: I'll be working on this as agreed in the UX SIG meeting

            Show
            romenrg Romen Rodriguez-Gil added a comment - - edited I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement. Are you OK if I take the ticket and play with it a bit? EDIT: I'll be working on this as agreed in the UX SIG meeting
            romenrg Romen Rodriguez-Gil made changes -
            Assignee Romen Rodriguez-Gil [ romenrg ]
            fqueiruga Félix Queiruga Balado made changes -
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            I found one more banner that should be updated as well:

            1. Go to the /user/admin/configure page
            2. Generate an API token
            3. Click the button to copy the API token to the clipboard

            Screenshot:

            Show
            fqueiruga Félix Queiruga Balado added a comment - I found one more banner that should be updated as well: Go to the /user/admin/configure page Generate an API token Click the button to copy the API token to the clipboard Screenshot:
            Hide
            romenrg Romen Rodriguez-Gil added a comment -

            Thanks Félix. I'll work on that one as well

            Show
            romenrg Romen Rodriguez-Gil added a comment - Thanks Félix. I'll work on that one as well
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.

            Show
            fqueiruga Félix Queiruga Balado added a comment - If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.
            romenrg Romen Rodriguez-Gil made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck made changes -
            Labels regression ux lts-candidate regression ux
            danielbeck Daniel Beck made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            danielbeck Daniel Beck made changes -
            Remote Link This issue links to "PR 4610 (Web Link)" [ 24807 ]
            Show
            romenrg Romen Rodriguez-Gil added a comment - PR:  https://github.com/jenkinsci/jenkins/pull/4610
            oleg_nenashev Oleg Nenashev made changes -
            Released As Jenkins 2.230
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate regression ux 2.222.2-rejected lts-candidate regression ux
            danielbeck Daniel Beck made changes -
            Link This issue causes JENKINS-62065 [ JENKINS-62065 ]
            olivergondza Oliver Gondža made changes -
            Labels 2.222.2-rejected lts-candidate regression ux 2.222.2-rejected JENKINS-61478 regression ux
            olivergondza Oliver Gondža made changes -
            Labels 2.222.2-rejected JENKINS-61478 regression ux 2.222.2-rejected 2.222.4-fixed regression ux
            olivergondza Oliver Gondža made changes -
            Labels 2.222.2-rejected 2.222.4-fixed regression ux 2.222.2-rejected 2.222.4-rejected regression ux

              People

              Assignee:
              romenrg Romen Rodriguez-Gil
              Reporter:
              danielbeck Daniel Beck
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: