Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62444

Add and check JCasC compatibility for email-ext plugin

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      2.72

      Description

      It would be great if email-ext was compatible with Jenkins Configuration as Code.
      This way the plugin could be configured at Jenkins startup with a single yaml file.

      There is already a bunch of PRs filed on other plugins doing the same, for example how it was done for kubernetes plugin:
      https://github.com/cloudbees/kube-agent-management-plugin/pull/128/files

      Basically the purpose is:

      • Review CasC support, and implement it if not already in place.
      • Review symbols and YAML format so that it's "nice". Example: avoid the unclassified group.
      • Create automated tests to validate the support.

      Thank you.

        Attachments

          Activity

          Hide
          alecharp Adrien Lecharpentier added a comment - - edited

          Thanks Alex. I saw the branch on thursday and it looked good. I'm wondering if we could also have a JCasC specific tests like in https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/integrations/src/test/java/io/jenkins/plugins/casc using a specific yml file to configure the plugin. This could serves as an example.

          I can send you a patch or do a PR against this branch for this. Should be able to do it in the next 24hrs.

          Show
          alecharp Adrien Lecharpentier added a comment - - edited Thanks Alex. I saw the branch on thursday and it looked good. I'm wondering if we could also have a JCasC specific tests like in https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/integrations/src/test/java/io/jenkins/plugins/casc using a specific yml file to configure the plugin. This could serves as an example. I can send you a patch or do a PR against this branch for this. Should be able to do it in the next 24hrs.
          Hide
          slide_o_mix Alex Earl added a comment -

          Yes, I would definitely like that . I am not super familiar with JCasC, so having someone who is would be great

          Show
          slide_o_mix Alex Earl added a comment - Yes, I would definitely like that . I am not super familiar with JCasC, so having someone who is would be great
          Hide
          alecharp Adrien Lecharpentier added a comment -

          Hi Alex Earl, I looked at the test and it seems pretty complete. Do you feel like you need to add something different? Maybe about the triggers, to show how to set them up?

          We could add a new unit test and a resource file with only the triggers for example.

          Show
          alecharp Adrien Lecharpentier added a comment - Hi Alex Earl , I looked at the test and it seems pretty complete. Do you feel like you need to add something different? Maybe about the triggers, to show how to set them up? We could add a new unit test and a resource file with only the triggers for example.
          Hide
          slide_o_mix Alex Earl added a comment -

          Yes, I think that would be good.

          Show
          slide_o_mix Alex Earl added a comment - Yes, I think that would be good.
          Show
          alecharp Adrien Lecharpentier added a comment - here it is: https://github.com/jenkinsci/email-ext-plugin/pull/211

            People

            Assignee:
            slide_o_mix Alex Earl
            Reporter:
            mramonleon Ramon Leon
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: