-
New Feature
-
Resolution: Fixed
-
Major
-
None
-
-
2.72
It would be great if email-ext was compatible with Jenkins Configuration as Code.
This way the plugin could be configured at Jenkins startup with a single yaml file.
There is already a bunch of PRs filed on other plugins doing the same, for example how it was done for kubernetes plugin:
https://github.com/cloudbees/kube-agent-management-plugin/pull/128/files
Basically the purpose is:
- Review CasC support, and implement it if not already in place.
- Review symbols and YAML format so that it's "nice". Example: avoid the unclassified group.
- Create automated tests to validate the support.
Thank you.
[JENKINS-62444] Add and check JCasC compatibility for email-ext plugin
Adrien, Now looking back on this, I remember why it was taking me longer to get it figured out. When using the binding instead of pulling data from the forms manually, there were some things I had to convert to individual jelly files for describable objects. I will push something to a branch soon, I appreciate the help!
Adrien Lecharpentier
added a comment - Mostly, I deleted the configure method and used @DataboundSetter on the setters. The main issue was on the filters and some other field.
Adrien Lecharpentier
added a comment - Mostly, I deleted the configure method and used @DataboundSetter on the setters. The main issue was on the filters and some other field. I did push a branch: https://github.com/jenkinsci/email-ext-plugin/tree/jcasc_updates, it currently builds and all tests pass, but I would like to extend the tests to do more tests of the global configuration since that is where a lot of changes are.
Thanks Alex. I saw the branch on thursday and it looked good. I'm wondering if we could also have a JCasC specific tests like in https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/integrations/src/test/java/io/jenkins/plugins/casc using a specific yml file to configure the plugin. This could serves as an example.
I can send you a patch or do a PR against this branch for this. Should be able to do it in the next 24hrs.
Adrien Lecharpentier
added a comment - - edited Thanks Alex. I saw the branch on thursday and it looked good. I'm wondering if we could also have a JCasC specific tests like in https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/integrations/src/test/java/io/jenkins/plugins/casc using a specific yml file to configure the plugin. This could serves as an example.
I can send you a patch or do a PR against this branch for this. Should be able to do it in the next 24hrs. Yes, I would definitely like that . I am not super familiar with JCasC, so having someone who is would be great
Adrien Lecharpentier
added a comment - Hi slide_o_mix, I looked at the test and it seems pretty complete. Do you feel like you need to add something different? Maybe about the triggers, to show how to set them up?
We could add a new unit test and a resource file with only the triggers for example.
Adrien Lecharpentier
added a comment - Hi slide_o_mix , I looked at the test and it seems pretty complete. Do you feel like you need to add something different? Maybe about the triggers, to show how to set them up?
We could add a new unit test and a resource file with only the triggers for example. Adrien Lecharpentier
added a comment - Adrien Lecharpentier
added a comment - here it is: https://github.com/jenkinsci/email-ext-plugin/pull/211
Alex, how can I help you with this task? Could you push your branch publicly, maybe we can divide the work to conquer..