Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62500

Help button breaks for some plugins with table to div changes

      Summary: Some help buttons when clicked jumps to the top or the bottom of the page.

      Tested docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester

      • Folders plugin (see screenshot and screen recordings attached)
      • Jenkins Health Advisor plugin (see screenshot)
        ...

      In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

      Other places where this occurs in the new version but not the previous one:

      Manage Jenkins > Configure Global Security

      • Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
      • CSRF Protection -> Enable proxy compatibility -> Help button
      • API Token -> Help buttons (3x)

      Freestyle job configuration

      • Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button
      • Post Build Actions -> Archive the artifacts -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x)
      • Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button

      A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin in both the previous and the PR test version. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

      Screenshots

      • Folders plugin - Health metrics in Configure System
        • folder-health-metric.png 
        • folder-health-metrics-before.mov
        • folder-health-metrics-after.mov
      • Health Advisor Plugin
        • health-advisor.png

       

        1. help-text-previous.png
          help-text-previous.png
          67 kB
        2. screenshot-2.png
          screenshot-2.png
          30 kB
        3. screenshot-1.png
          screenshot-1.png
          10 kB
        4. folder-health-metrics-after.mov
          1.53 MB
        5. folder-health-metrics-before.mov
          334 kB
        6. health-advisor.png
          health-advisor.png
          32 kB
        7. folder-health-metric.png
          folder-health-metric.png
          56 kB

          [JENKINS-62500] Help button breaks for some plugins with table to div changes

          megathaum created issue -
          megathaum made changes -
          Epic Link New: JENKINS-62437 [ 206431 ]
          megathaum made changes -
          Description Original: Summary: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          New: Summary: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          +Manage Jenkins > Configure Global Security+
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          megathaum made changes -
          Description Original: Summary: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          +Manage Jenkins > Configure Global Security+
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          New: *Summary*: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          Manage Jenkins > Configure Global Security
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          megathaum made changes -
          Description Original: *Summary*: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          Manage Jenkins > Configure Global Security
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          New: *Summary*: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          Manage Jenkins > Configure Global Security
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          Freestyle job configuration
           * Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button
           * Post Build Actions -> Archive the artifacts -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x)
           * Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          megathaum made changes -
          Description Original: *Summary*: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested `docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester`
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          Manage Jenkins > Configure Global Security
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          Freestyle job configuration
           * Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button
           * Post Build Actions -> Archive the artifacts -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x)
           * Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          New: *Summary*: Some help buttons when clicked jumps to the top or the bottom of the page.

          Tested {{docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester}}
           * Folders plugin (see screenshot and screen recordings attached)
           * Jenkins Health Advisor plugin (see screenshot)
           ...

          In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.

          Other places where this occurs in the new version but not the previous one:

          Manage Jenkins > Configure Global Security
           * Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
           * CSRF Protection -> Enable proxy compatibility -> Help button
           * API Token -> Help buttons (3x)

          Freestyle job configuration
           * Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button
           * Post Build Actions -> Archive the artifacts -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x)
           * Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button

          A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin *in both the previous and the PR test version*. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).

          *Screenshots*
           * Folders plugin - Health metrics in Configure System
           ** folder-health-metric.png 
           ** folder-health-metrics-before.mov
           ** folder-health-metrics-after.mov
           * Health Advisor Plugin
           ** health-advisor.png

           
          Tim Jacomb made changes -
          Attachment New: screenshot-1.png [ 51372 ]

          Tim Jacomb added a comment -

          Tim Jacomb added a comment - Cloudbees-health advisor plugin has javascript errors when you click the help button: code: https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/blob/master/src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly#L122

          Tim Jacomb added a comment -

          JavaScript:

          var tr = findFollowingTR(this, "help-area", "help-sibling") ||
          findFollowingTR(this, "help-area", "setting-help");
          var div = $(tr).down();

          cc fqueiruga

          Tim Jacomb added a comment - JavaScript: var tr = findFollowingTR(this, "help-area", "help-sibling") || findFollowingTR(this, "help-area", "setting-help"); var div = $(tr).down(); cc fqueiruga
          Francisco Fernández made changes -
          Assignee Original: Francisco Fernández [ fcojfernandez ]

            fqueiruga Félix Queiruga Balado
            megathaum megathaum
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: