Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62560

Buttons linger when closing modal

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Released As:
      Jenkins 2.240

      Description

      Jenkins 2.233 introduced changes to the button. Since then, button position and visibility seem to be "animated" and it causes buttons to linger when closing modals.

      Steps

      • Open a modal like the one to select repo credentials on a pipeline.
      • Close the modal.
      • Notice that the buttons linger for a bit before fading out.

      Attached screenshots with the modal open and the lingering effect.

        Attachments

          Activity

          fqueiruga Félix Queiruga Balado created issue -
          fqueiruga Félix Queiruga Balado made changes -
          Field Original Value New Value
          Epic Link JENKINS-60919 [ 204316 ]
          fqueiruga Félix Queiruga Balado made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          fqueiruga Félix Queiruga Balado made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          PR here: https://github.com/jenkinsci/jenkins/pull/4770

          Oliver Gondža I guess this can be considered a regression from 2.233. It's not a big bug so I have no opinions whether this should be backported to this release, assuming it gets merged soon ofc. I'd vote to include it on the July one at least though. Thoughts?

          Show
          fqueiruga Félix Queiruga Balado added a comment - PR here: https://github.com/jenkinsci/jenkins/pull/4770 Oliver Gondža I guess this can be considered a regression from 2.233. It's not a big bug so I have no opinions whether this should be backported to this release, assuming it gets merged soon ofc. I'd vote to include it on the July one at least though. Thoughts?
          danielbeck Daniel Beck made changes -
          Labels lts-candidate
          Hide
          olivergondza Oliver Gondža added a comment -

          Félix Queiruga Balado, sure, it is too late for 2.235.1 but for the .2 this might be a valid candidate. I see the label is in place so it will be considered provided it will be resolved by then.

          Show
          olivergondza Oliver Gondža added a comment - Félix Queiruga Balado , sure, it is too late for 2.235.1 but for the .2 this might be a valid candidate. I see the label is in place so it will be considered provided it will be resolved by then.
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          Understood, thanks!

          Show
          fqueiruga Félix Queiruga Balado added a comment - Understood, thanks!
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          Oleg Nenashev can this be resolved?

          Show
          fqueiruga Félix Queiruga Balado added a comment - Oleg Nenashev can this be resolved?
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Félix Queiruga Balado yes, fixed. Usually we expect fix submitters to resolve the issues, and we just do a cleanup afterwards. But everyone was busy with other fires

          Show
          oleg_nenashev Oleg Nenashev added a comment - Félix Queiruga Balado yes, fixed. Usually we expect fix submitters to resolve the issues, and we just do a cleanup afterwards. But everyone was busy with other fires
          oleg_nenashev Oleg Nenashev made changes -
          Released As Jenkins 2.240
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          olivergondza Oliver Gondža made changes -
          Labels lts-candidate 2.235.1-fixed
          olivergondza Oliver Gondža made changes -
          Labels 2.235.1-fixed 2.235.2-fixed

            People

            Assignee:
            fqueiruga Félix Queiruga Balado
            Reporter:
            fqueiruga Félix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: