-
Task
-
Resolution: Fixed
-
Minor
-
None
-
-
cloudbees-jenkins-advisor-3.2.0
Reported in the dark-theme plugin ( https://github.com/jenkinsci/dark-theme-plugin/issues/79 ) by timja and confirmed by fqueiruga using Bootstrap in the admin panel is causing various rendering issue (Bootstrap causes the specific pages where it's used to have a different font and basic theme than the rest of the UI.)
AFAICS Bootstrap is used for the alert boxes used in the admin page (success, info, warning, error) and Bootstrap was imported to match what was done in the "Manage Jenkins" screen for monitors
It seems possible to do without it ... let's try
- relates to
-
JENKINS-62747 Add an .alert-success variant
-
- Resolved
-
[JENKINS-62739] Do not use Bootstrap style in Advisor admin page
There is no info alert support without bootstrap for that version of Jenkins. It shouldn't be hard to extract the specific CSS from the bootstrap CSS code and then add some flavour to make it compatible with theming.
| Description |
Original:
Reported in the dark-theme plugin ( [https://github.com/jenkinsci/dark-theme-plugin/issues/79] ) by [~timja] and confirmed by [~fqueiruga] using Bootstrap in the admin panel is causing various rendering issue (Bootstrap causes the specific pages where it's used to have a different font and basic theme than the rest of the UI.) It seems possible to do without it ... let's try |
New:
Reported in the dark-theme plugin ( [https://github.com/jenkinsci/dark-theme-plugin/issues/79] ) by [~timja] and confirmed by [~fqueiruga] using Bootstrap in the admin panel is causing various rendering issue (Bootstrap causes the specific pages where it's used to have a different font and basic theme than the rest of the UI.) AFAICS Bootstrap is used for the alert boxes used in the admin page (success, info, warning, error) and Bootstrap was imported to match what was done in the "Manage Jenkins" screen for monitors It seems possible to do without it ... let's try |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
fqueiruga I can potentially upgrade the required version.
The plugin isn't evolving a lot (improvements are mainly on the server side) thus it shouldn't be risky to upgrade. Oldest versions of Jenkins can use the 3.1 version
Maybe 2.204 can be a good new baseline target. There would still be some work needed to make it forward-compatible with theming but nothing to worry about.
FWIW bootstrap was removed from the /manage page on 2.226.
The minimum version is 2.200
https://github.com/jenkinsci/jenkins/pull/4276
https://issues.jenkins-ci.org/browse/JENKINS-59684
alert-danger, alert-info, alert-warning
fqueiruga it is fine for me to upgrade the requirement to 2.204 LTS ( Released 6 months ago - 2019-12-18 )
Can you help me for backporting the CSS?
Otherwise if you have any other / better approach to make visible the alert messages feel free to propose something else.
A part of the screenshots showing the usage of these alert boxes are visible in https://issues.jenkins-ci.org/browse/JENKINS-59648 and https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/pull/37
fqueiruga, timja should I import a specific CSS file to be able to have some "alert" boxes without bootstrap?
My baseline is Jenkins 2.138.4