Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62779

HTTP proxy vars not respected in branch plugin

    XMLWordPrintable

Details

    Description

      We're having a similar problem to JENKINS-23895 where the gitlab-branch-source-plugin is not respecting the http_proxy variables.

      https://github.com/gitlab4j/gitlab4j-api#connecting-through-a-proxy-server shows how to pass in proxy config. Line 95ish in GitLabHookCreator.java is an example of where proxy config is missing. 

      There are 7 places where the plugin does new GitLabApi(..) and does not pass any proxy config

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          alex_flux Alex Deng created issue -
          alex_flux Alex Deng made changes -
          Field Original Value New Value
          Description We're having a similar problem to JENKINS-23895 where the gitlab-branch-source-plugin is not respecting the http_proxy variables. We're having a similar problem to JENKINS-23895 where the gitlab-branch-source-plugin is not respecting the http_proxy variables.

          [https://github.com/gitlab4j/gitlab4j-api#connecting-through-a-proxy-server] shows how to pass in proxy config. Line 95ish in GitLabHookCreator.java is an example of where proxy config is missing. 

          There are 7 places where the plugin does new GitLabApi(..) and does not pass any proxy config
          mver Michael Völker added a comment - - edited

          baymac Is there a timeline to implement this?

          This is the only issue that prevents us from using the plugin.

          Looks like this is rather a feature than a bug. 

          mver Michael Völker added a comment - - edited baymac Is there a timeline to implement this? This is the only issue that prevents us from using the plugin. Looks like this is rather a feature than a bug. 
          bitwiseman Liam Newman added a comment - - edited

          alex_flux mver
          This functionality is available in github-branch-source and is relative easy to add. Do you have time to submit a PR?

          bitwiseman Liam Newman added a comment - - edited alex_flux mver This functionality is available in github-branch-source and is relative easy to add. Do you have time to submit a PR?
          jdelpech Jean-Baptiste Delpech added a comment -

          Hi there, I opened a PR to add corporate proxy support : https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/124

           

          Feel free to make suggestion / improvments.

          jdelpech Jean-Baptiste Delpech added a comment - Hi there, I opened a PR to add corporate proxy support : https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/124   Feel free to make suggestion / improvments.
          tom_gl Thomas de Grenier de Latour added a comment -

          PR 124 (plugin version 1.5.5) has introduced a regression in my use case, because it ignores the "No proxy host" settings (our proxy is for internet only and our GitLab server is on intranet).

          Proposed fix: https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/133

          tom_gl Thomas de Grenier de Latour added a comment - PR 124 (plugin version 1.5.5) has introduced a regression in my use case, because it ignores the "No proxy host" settings (our proxy is for internet only and our GitLab server is on intranet). Proposed fix: https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/133

          People

            baymac Parichay Barpanda
            alex_flux Alex Deng
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated: