Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62789

htmlpublisher plugin may break with tables-to-divs

    XMLWordPrintable

Details

    Description

      The htmlpublisher plugin contains a fork of the f:repeatableProperty __ widget and may break with the form-tables-to-divs changes: https://github.com/jenkinsci/htmlpublisher-plugin/blob/master/src/main/resources/htmlpublisher/lib/repeatableProperty.jelly

      It needs to be reviewed and fixed.

       

      Attachments

        Activity

          fqueiruga Félix Queiruga Balado created issue -
          fqueiruga Félix Queiruga Balado made changes -
          Field Original Value New Value
          Epic Link JENKINS-62437 [ 206431 ]
          fqueiruga Félix Queiruga Balado made changes -
          Issue Type Story [ 10002 ] Bug [ 1 ]

          Thanks fqueiruga - is there a branch somewhere of the fork-origin that has the required change in it? (To try and discover whether the best approach is to revert back to the original or reapply the same fix in the fork)

          r2b2_nz Richard Bywater added a comment - Thanks fqueiruga - is there a branch somewhere of the fork-origin that has the required change in it? (To try and discover whether the best approach is to revert back to the original or reapply the same fix in the fork)
          timja Tim Jacomb added a comment -

          Hi r2b2_nz

          The pull request you can validate it against is:
          https://github.com/jenkinsci/jenkins/pull/3895

          Ideally it would be best to switch back to the original, or upstream the required changes.

          Thanks!

          timja Tim Jacomb added a comment - Hi r2b2_nz The pull request you can validate it against is: https://github.com/jenkinsci/jenkins/pull/3895 Ideally it would be best to switch back to the original, or upstream the required changes. Thanks!
          jsoref Josh Soref added a comment -

          r2b2_nz

          jsoref Josh Soref added a comment - r2b2_nz Quick-start:  https://github.com/oleg-nenashev/jenkins-tabs-to-divs-config-migration-testenv Manual setup:  docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester

          Hi r2b2_nz, these changes are now on the master branch of Jenkins ever since version 2.265.

          fqueiruga Félix Queiruga Balado added a comment - Hi r2b2_nz , these changes are now on the master branch of Jenkins ever since version 2.265.

          olamy Would you happen to have some time to look into this? I've been meaning to for a while now but kept getting sidetracked with other personal/work stuff...

          r2b2_nz Richard Bywater added a comment - olamy  Would you happen to have some time to look into this? I've been meaning to for a while now but kept getting sidetracked with other personal/work stuff...

          Have reviewed and even without the change layout still seems to be ok from what I can see. However I have a PR open (https://github.com/jenkinsci/htmlpublisher-plugin/pull/99) to revert back to the normal repeatableProperty. I'm not sure why it was actually ever forked as it appears that it was due to the lack of invokeBody which actually appeared to have existed at the time anyway but perhaps the Git log doesn't tell the full story

          r2b2_nz Richard Bywater added a comment - Have reviewed and even without the change layout still seems to be ok from what I can see. However I have a PR open ( https://github.com/jenkinsci/htmlpublisher-plugin/pull/99)  to revert back to the normal repeatableProperty. I'm not sure why it was actually ever forked as it appears that it was due to the lack of invokeBody which actually appeared to have existed at the time anyway but perhaps the Git log doesn't tell the full story
          r2b2_nz Richard Bywater made changes -
          Released As https://github.com/jenkinsci/htmlpublisher-plugin/releases/tag/htmlpublisher-1.24
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]

          People

            r2b2_nz Richard Bywater
            fqueiruga Félix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: