• Icon: Bug Bug
    • Resolution: Not A Defect
    • Icon: Blocker Blocker
    • email-ext-plugin
    • None
    • Jenkins 2.235.3, JCasC 1.42, Email-Ext 2.72

      After update to Jenkins plugins, Email-Ext plugin causes a load failure by JCasC.  See attached.

      Have to downgrade to2.71 to get Jenkins to start again.

      Has changes for JCasC configuration code changed?

       

          [JENKINS-63292] Email-ext 2.72 and JCasC cause launch failure

          Alex Earl added a comment -

          alecharp Any help here? I am not super familiar with JCasC

          Alex Earl added a comment - alecharp Any help here? I am not super familiar with JCasC

          Could you make fix the indentation (welcome to the YAML world (sarcasm)) on the configuration example you provided?

          From what I understand of the stack-trace, it seems that the useSsl is being read by the unclassified category. It seems odd.

          Adrien Lecharpentier added a comment - Could you make fix the indentation (welcome to the YAML world (sarcasm)) on the configuration example you provided? From what I understand of the stack-trace, it seems that the useSsl is being read by the unclassified category. It seems odd.

          Adrien Lecharpentier added a comment - Please see the example on the plugin repository: https://github.com/jenkinsci/email-ext-plugin/blob/master/src/test/resources/configuration-as-code.yml

          Alan Sparks added a comment - - edited

          I'll look at the provided config snippet and try to make it work.   It appears there is a serious change in the configuration block, since it worked with the previous indentation.

          It might be a good idea to let people know this appears to be a breaking change for those using JCasC...

          Alan Sparks added a comment - - edited I'll look at the provided config snippet and try to make it work.   It appears there is a serious change in the configuration block, since it worked with the previous indentation. It might be a good idea to let people know this appears to be a breaking change for those using JCasC...

          Alan Sparks added a comment -

          alecharp slide_o_mix Looking at your configuration this is very different from what was working with the last version of email-ext.  Is there any description of all those config items, and which are required?  Especially when talking of new levels, like "addAccount" and "mailAccount".

          Alan Sparks added a comment - alecharp slide_o_mix Looking at your configuration this is very different from what was working with the last version of email-ext.  Is there any description of all those config items, and which are required?  Especially when talking of new levels, like "addAccount" and "mailAccount".

          webminster to be honest, I don't think we can say that version prior to 2.72 were JCasC compatible. Sure, some fields were configurable but the complete configuration was not possible.

          slide_o_mix did a great job at making sure that everything was configurable through JCasC.

          We could advertise that if anyone was configuring email-ext with JCasC using a version prior to 2.72, then that configuration is no longer compatible.

          This is due to the fact that:

          1. JCasC team did a great job at trying to make as many plugin compatible as possible out of the box. This is why some fields were configurable
          2. however, due to the legacy code in email-ext and the way some fields were configured before (through the UI and some hack in the Java code), slide_o_mix had to refactor those elements.

          I do understand  this is not really what you wish to ear webminster, but in the end, the plugin was not compatible with JCasC before 2.72.

          Adrien Lecharpentier added a comment - webminster to be honest, I don't think we can say that version prior to 2.72 were JCasC compatible. Sure, some fields were configurable but the complete configuration was not possible. slide_o_mix did a great job at making sure that everything was configurable through JCasC. We could advertise that if anyone was configuring email-ext with JCasC using a version prior to 2.72 , then that configuration is no longer compatible. This is due to the fact that: JCasC team did a great job at trying to make as many plugin compatible as possible out of the box. This is why some fields were configurable however, due to the legacy code in email-ext and the way some fields were configured before (through the UI and some hack in the Java code), slide_o_mix had to refactor those elements. I do understand  this is not really what you wish to ear webminster , but in the end, the plugin was not compatible with JCasC before 2.72 .

          Alex Earl added a comment -

          This is the first version that JCasC is actually supported in email-ext. I don't know if there is a way to migrate the JCasC settings from a version where it was not supported to a version where it is. JCasC is very new to me. I implemented the changes required for the support, but I don't know much about JCasC itself.

          Alex Earl added a comment - This is the first version that JCasC is actually supported in email-ext. I don't know if there is a way to migrate the JCasC settings from a version where it was not supported to a version where it is. JCasC is very new to me. I implemented the changes required for the support, but I don't know much about JCasC itself.

          Alan Sparks added a comment -

          OK, that's fair enough - been the second plugin in 2 weeks that required a jenkins.yaml redo because of JCasC support, so very surprised.  Since I'd found JCasC configs for this plugin on the Net was not aware that it wasn't "officially" supported.

          Now that I know this is an issue I can deal with it.  Thanks.

          Alan Sparks added a comment - OK, that's fair enough - been the second plugin in 2 weeks that required a jenkins.yaml redo because of JCasC support, so very surprised.  Since I'd found JCasC configs for this plugin on the Net was not aware that it wasn't "officially" supported. Now that I know this is an issue I can deal with it.  Thanks.

          Alex Earl added a comment -

          I wish I knew more about JCasC to be able to come up with a better solution. My apologies that it caused you issues.

          Alex Earl added a comment - I wish I knew more about JCasC to be able to come up with a better solution. My apologies that it caused you issues.

          Alan Sparks added a comment -

          Thanks.  And thanks alecharp for the pointer to the test config, that helped me change mine.

          Alan Sparks added a comment - Thanks.  And thanks alecharp for the pointer to the test config, that helped me change mine.

            slide_o_mix Alex Earl
            webminster Alan Sparks
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: