Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63292

Email-ext 2.72 and JCasC cause launch failure

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Not A Defect
    • Component/s: email-ext-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.235.3, JCasC 1.42, Email-Ext 2.72
    • Similar Issues:

      Description

      After update to Jenkins plugins, Email-Ext plugin causes a load failure by JCasC.  See attached.

      Have to downgrade to2.71 to get Jenkins to start again.

      Has changes for JCasC configuration code changed?

       

        Attachments

          Activity

          Hide
          alecharp Adrien Lecharpentier added a comment -

          Alan Sparks to be honest, I don't think we can say that version prior to 2.72 were JCasC compatible. Sure, some fields were configurable but the complete configuration was not possible.

          Alex Earl did a great job at making sure that everything was configurable through JCasC.

          We could advertise that if anyone was configuring email-ext with JCasC using a version prior to 2.72, then that configuration is no longer compatible.

          This is due to the fact that:

          1. JCasC team did a great job at trying to make as many plugin compatible as possible out of the box. This is why some fields were configurable
          2. however, due to the legacy code in email-ext and the way some fields were configured before (through the UI and some hack in the Java code), Alex Earl had to refactor those elements.

          I do understand  this is not really what you wish to ear Alan Sparks, but in the end, the plugin was not compatible with JCasC before 2.72.

          Show
          alecharp Adrien Lecharpentier added a comment - Alan Sparks to be honest, I don't think we can say that version prior to 2.72 were JCasC compatible. Sure, some fields were configurable but the complete configuration was not possible. Alex Earl did a great job at making sure that everything was configurable through JCasC. We could advertise that if anyone was configuring email-ext with JCasC using a version prior to 2.72 , then that configuration is no longer compatible. This is due to the fact that: JCasC team did a great job at trying to make as many plugin compatible as possible out of the box. This is why some fields were configurable however, due to the legacy code in email-ext and the way some fields were configured before (through the UI and some hack in the Java code), Alex Earl had to refactor those elements. I do understand  this is not really what you wish to ear Alan Sparks , but in the end, the plugin was not compatible with JCasC before 2.72 .
          Hide
          slide_o_mix Alex Earl added a comment -

          This is the first version that JCasC is actually supported in email-ext. I don't know if there is a way to migrate the JCasC settings from a version where it was not supported to a version where it is. JCasC is very new to me. I implemented the changes required for the support, but I don't know much about JCasC itself.

          Show
          slide_o_mix Alex Earl added a comment - This is the first version that JCasC is actually supported in email-ext. I don't know if there is a way to migrate the JCasC settings from a version where it was not supported to a version where it is. JCasC is very new to me. I implemented the changes required for the support, but I don't know much about JCasC itself.
          Hide
          webminster Alan Sparks added a comment -

          OK, that's fair enough - been the second plugin in 2 weeks that required a jenkins.yaml redo because of JCasC support, so very surprised.  Since I'd found JCasC configs for this plugin on the Net was not aware that it wasn't "officially" supported.

          Now that I know this is an issue I can deal with it.  Thanks.

          Show
          webminster Alan Sparks added a comment - OK, that's fair enough - been the second plugin in 2 weeks that required a jenkins.yaml redo because of JCasC support, so very surprised.  Since I'd found JCasC configs for this plugin on the Net was not aware that it wasn't "officially" supported. Now that I know this is an issue I can deal with it.  Thanks.
          Hide
          slide_o_mix Alex Earl added a comment -

          I wish I knew more about JCasC to be able to come up with a better solution. My apologies that it caused you issues.

          Show
          slide_o_mix Alex Earl added a comment - I wish I knew more about JCasC to be able to come up with a better solution. My apologies that it caused you issues.
          Hide
          webminster Alan Sparks added a comment -

          Thanks.  And thanks Adrien Lecharpentier for the pointer to the test config, that helped me change mine.

          Show
          webminster Alan Sparks added a comment - Thanks.  And thanks Adrien Lecharpentier for the pointer to the test config, that helped me change mine.

            People

            Assignee:
            slide_o_mix Alex Earl
            Reporter:
            webminster Alan Sparks
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: