Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: git-plugin
-
Labels:None
-
Environment:Jenkins 2.235.5
Git plugin 4.4.0
-
Similar Issues:
-
Released As:git plugin 4.4.3
Description
The git tool chooser will use locally cached copies of git repositories to estimate repository size. However, the cache lookup uses the repository URL as the cache lookup key. Git repositories on all major providers can be accessed from multiple URLs where the different URLs represent the same repository.
For example, https://github.com/jenkinsci/git-plugin and https://github.com/jenkinsci/git-plugin.git are the same repository but cache lookup by the repository URL will find at most one of those two.
Should extend the repository cache lookup process to better use the cached copies.
PR-947 needs to be discarded and reworked into something better as a new pull request. The mistakes I made in that pull request include:
The code that looks for caches on the Jenkins controller by different repository URL variants is likely still useful, since the user may have defined a multibranch repository using an alternate form. However, by checking the cache in memory first, we may avoid most of the work checking different forms of repository URL to see if a cache exists for that URL.