Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63900

display name can no longer be used as graph label

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • robot-plugin
    • Robot Framework plugin 2.1.2
    • 3.5.1

      Before the PR from JENKINS-35327, the build numbers we set using plugin Set Build Number was shown on the graph, after the PR was merged the trend graph always shows the internal build number and not our customized build number.

          [JENKINS-63900] display name can no longer be used as graph label

          Aleksi Simell added a comment -

          Hi vitorego,

          The PR you're referring to changed it so that the x-axel is configured from the Robot Framework section of the global configurations. By default it is  #$build. Can you try setting this value to the same value as you set with your customized build number? I'll check how easy this would be to overwrite when custom build number is used.

          Aleksi Simell added a comment - Hi vitorego , The PR you're referring to changed it so that the x-axel is configured from the Robot Framework section of the global configurations. By default it is   #$build . Can you try setting this value to the same value as you set with your customized build number? I'll check how easy this would be to overwrite when custom build number is used.

          Vitor Rego added a comment - - edited

          Hi aleksisimell, I did try to set the custom variable in the global configurations but did not work.

          Vitor Rego added a comment - - edited Hi aleksisimell , I did try to set the custom variable in the global configurations but did not work.

          Aleksi Simell added a comment -

          vitorego Can you please provide an example how you're setting your custom build number?

          Aleksi Simell added a comment - vitorego Can you please provide an example how you're setting your custom build number?

          Vitor Rego added a comment -

          aleksisimell: here it is:

          We use a custom variable defined in the job.

           

          Vitor Rego added a comment - aleksisimell : here it is: We use a custom variable defined in the job.  

          Aleksi Simell added a comment -

          Thank you. I already created a pull request to resolve this issue, but I haven't created unit tests for that (yet), so I'll probably merge the change after Christmas break.

          Aleksi Simell added a comment - Thank you. I already created a pull request to resolve this issue, but I haven't created unit tests for that (yet), so I'll probably merge the change after Christmas break.

          Aleksi Simell added a comment -

          PR merged. Will be available in next release.

          Aleksi Simell added a comment - PR merged. Will be available in next release.

          Vitor Rego added a comment -

          Hi Aleksi,

          I installed the new plugin version 2.2.0 and the issue still persists, if I use the ENV variable $TNMS_VERSION the graph does not show anything after I clear my browser's cache.

          Vitor Rego added a comment - Hi Aleksi, I installed the new plugin version 2.2.0 and the issue still persists, if I use the ENV variable $TNMS_VERSION the graph does not show anything after I clear my browser's cache.

          Aleksi Simell added a comment -

          vitorego I haven't been able to reproduce this. Can you provide example steps to reproduce this issue?

          Aleksi Simell added a comment - vitorego I haven't been able to reproduce this. Can you provide example steps to reproduce this issue?

          Vitor Rego added a comment -

          This variable is a environment variable of the job and as soon I set it here, the graph does not show anything:

           

          Vitor Rego added a comment - This variable is a environment variable of the job and as soon I set it here, the graph does not show anything:  

          Vitor Rego added a comment -

          Robot Plugin:

          Vitor Rego added a comment - Robot Plugin:

          Aleksi Simell added a comment -

          Seems that this issue persists only in freestyle jobs. In pipelines it works as intended. Let me investigate further and try to find a fix for this.

          Aleksi Simell added a comment - Seems that this issue persists only in freestyle jobs. In pipelines it works as intended. Let me investigate further and try to find a fix for this.

          Aleksi Simell added a comment -

          Aleksi Simell added a comment - https://github.com/jenkinsci/robot-plugin/pull/39 created to resolve this issue.

          Aleksi Simell added a comment -

          PR merged. Will be available in next release.

          Aleksi Simell added a comment - PR merged. Will be available in next release.

          Aleksi Simell added a comment -

          New version released (it will take up to 8 hours to show in update-center).

          Aleksi Simell added a comment - New version released (it will take up to 8 hours to show in update-center).

          Vitor Rego added a comment - - edited

          Hi aleksisimell, I´m not sure if version 3.0.0 might fix the issue, but still not fixed:

          If I set the variable I want in the global settings, the graph does not show anything, even after I clean by browser´s cache:

           

          Vitor Rego added a comment - - edited Hi aleksisimell , I´m not sure if version 3.0.0 might fix the issue, but still not fixed: If I set the variable I want in the global settings, the graph does not show anything, even after I clean by browser´s cache:  

          Aleksi Simell added a comment -

          vitorego you can specify the label per job now. Try that.

          Aleksi Simell added a comment - vitorego you can specify the label per job now. Try that.

          Aleksi Simell added a comment -

          vitorego Did configuring the label for the job resolve your issue?

          Aleksi Simell added a comment - vitorego Did configuring the label for the job resolve your issue?

          Vitor Rego added a comment -

          Hi aleksisimell, using the setting per job the graph is updated, however all builds in the graph are updated with the latest build:

          Vitor Rego added a comment - Hi aleksisimell , using the setting per job the graph is updated, however all builds in the graph are updated with the latest build:

          Aleksi Simell added a comment - - edited

          I'm actually genuinely surprised that has even worked in the first place. Digging back to earlier PR it used NumberOnlyBuildLabel, which is supposed to return integers only.

          Aleksi Simell added a comment - - edited I'm actually genuinely surprised that has even worked in the first place. Digging back to earlier PR it used NumberOnlyBuildLabel , which is supposed to return integers only.

          Aleksi Simell added a comment -

          Reopening the issue again, as this is clearly not fixed yet.

          Aleksi Simell added a comment - Reopening the issue again, as this is clearly not fixed yet.

          Vitor Rego added a comment -

          The graph now is showing the build number, but the same buid number (the last one) is used for all the runs:

          Vitor Rego added a comment - The graph now is showing the build number, but the same buid number (the last one) is used for all the runs:

          Aleksi Simell added a comment -

          Finally managed to fix this. Pull Request created to fix this issue. The root cause is that you don't actually want to use build number as the label, but rather the build display name. This PR adds possibility to use display name as the label.

          Aleksi Simell added a comment - Finally managed to fix this. Pull Request created to fix this issue. The root cause is that you don't actually want to use build number as the label, but rather the build display name . This PR adds possibility to use display name as the label.

          Aleksi Simell added a comment -

          PR merged. Fix will be available in the next release.

          Aleksi Simell added a comment - PR merged. Fix will be available in the next release.

            aleksisimell Aleksi Simell
            vitorego Vitor Rego
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: