Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64241

TFS plugin broken since 2.264 (tables to divs)

    XMLWordPrintable

Details

    Description

      If I want to save my multi project job I get the error/callstack from attached "exception.txt". Please find attached the project file (minimalized to get this error). If I open it and press "apply" or "save" I got this error. This issue starts with 2.264. looks similar to issue https://issues.jenkins.io/browse/JENKINS-5118

       

      BTW pressing "apply" opens a new frame with error where the link to get callstack is not working

       

      Attachments

        1. config.xml
          0.9 kB
        2. exception.txt
          14 kB
        3. jenkinsPlugins.txt
          8 kB
        4. jenkinsPluginsWithCurl.txt
          3 kB
        5. screenshot_apply.png
          screenshot_apply.png
          28 kB
        6. screenshot_save.png
          screenshot_save.png
          11 kB

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev added a comment -

            Looks to be a table to divs issue

            oleg_nenashev Oleg Nenashev added a comment - Looks to be a table to divs issue
            timja Tim Jacomb added a comment -

            Hi please see https://issues.jenkins.io/browse/JENKINS-64072

            Without a full plugins list and a screenshot we can't reproduce this

            timja Tim Jacomb added a comment - Hi please see https://issues.jenkins.io/browse/JENKINS-64072 Without a full plugins list and a screenshot we can't reproduce this

            I added screenshots and plugin list. The issue appears only on press "Save" or "Apply".

            arbeita Ronny Borchert added a comment - I added screenshots and plugin list. The issue appears only on press "Save" or "Apply".
            timja Tim Jacomb added a comment -

            Can you use the script please:

            JENKINS_HOST=username:password@myhost.com:port
            curl -sSL "http://$JENKINS_HOST/pluginManager/api/xml?depth=1&xpath=/*/*/shortName|/*/*/version&wrapper=plugins" | perl -pe 's/.*?<shortName>([\w-]+).*?<version>([^<]+)()(<\/\w+>)+/\1 \2\n/g'|sed 's/ /:/'
            
            timja Tim Jacomb added a comment - Can you use the script please: JENKINS_HOST=username:password@myhost.com:port curl -sSL "http: //$JENKINS_HOST/pluginManager/api/xml?depth=1&xpath= /*/*/ shortName| /*/*/ version&wrapper=plugins" | perl -pe 's/.*?<shortName>([\w-]+).*?<version>([^<]+)()(<\/\w+>)+/\1 \2\n/g' |sed 's/ /:/'

            I attached it now. Having a ! in password is bad for seldom bash user , thats why I did it with the jenkins groovy script via console.

            arbeita Ronny Borchert added a comment - I attached it now. Having a ! in password is bad for seldom bash user , thats why I did it with the jenkins groovy script via console.
            timja Tim Jacomb added a comment -

            arbeita creating an API token is probably a safer way, but thanks

            timja Tim Jacomb added a comment - arbeita creating an API token is probably a safer way, but thanks
            timja Tim Jacomb added a comment -

            This appears to be the TFS plugin which has been suspended due to licensing issues and is not available in new installations (I had to build it from source to test it as I couldn't download it)

            see https://issues.jenkins.io/browse/INFRA-2751

            I don't intend to patch this myself but you or someone else could provide a patch and build from source or CI.
            It won't be possible for a release to be done until the licensing issue is addressed

            timja Tim Jacomb added a comment - This appears to be the TFS plugin which has been suspended due to licensing issues and is not available in new installations (I had to build it from source to test it as I couldn't download it) see https://issues.jenkins.io/browse/INFRA-2751 I don't intend to patch this myself but you or someone else could provide a patch and build from source or CI. It won't be possible for a release to be done until the licensing issue is addressed

            I could give it a try, my problem is only that if I would create a pull request nobody will merge it. My merge request is still open for a simple none code change.

            arbeita Ronny Borchert added a comment - I could give it a try, my problem is only that if I would create a pull request nobody will merge it. My merge request is still open for a simple none code change.

            I could figure out that on save/apply the send JSON is different than before. 

            hudson-triggers-SCMTrigger":true

            is no array

            This is the root cause, but could not find any jelly issue by my self. Is there now a maintainer for tfs plugin? Since the license things seems resolved. But nobody merge in pull requests on github.

            arbeita Ronny Borchert added a comment - I could figure out that on save/apply the send JSON is different than before.  hudson-triggers-SCMTrigger":true is no array This is the root cause, but could not find any jelly issue by my self. Is there now a maintainer for tfs plugin? Since the license things seems resolved. But nobody merge in pull requests on github.
            markewaite Mark Waite added a comment -

            arbeita I've not seen anyone asking to adopt the TFS plugin.

            Since you're submitting pull requests and you have access to a TFS environment where you can test it, it seems like a good case for you to offer to adopt the plugin. If you're comfortable submitting pull requests, you'll probably be comfortable as the maintainer. Thanks in advance if you choose to adopt it. I'm sure there are many users that will thank you.

            markewaite Mark Waite added a comment - arbeita I've not seen anyone asking to adopt the TFS plugin. Since you're submitting pull requests and you have access to a TFS environment where you can test it, it seems like a good case for you to offer to adopt the plugin . If you're comfortable submitting pull requests, you'll probably be comfortable as the maintainer. Thanks in advance if you choose to adopt it. I'm sure there are many users that will thank you.

            Thanks for your honor. But I have not enough spare time to fix it. Since as you can see, I try it since december 2020, 4 month, no real result.

            arbeita Ronny Borchert added a comment - Thanks for your honor. But I have not enough spare time to fix it. Since as you can see, I try it since december 2020, 4 month, no real result.
            glevy Gilad added a comment -

            Did any one by chance looked at the code and can suggest the required changes?

            Being able to build an unofficial fixed version will help remove some pressure on setups like ours where this plugin is mandatory for production.

            I'm sure it will be appreciated by many users. 

             

            glevy Gilad added a comment - Did any one by chance looked at the code and can suggest the required changes? Being able to build an unofficial fixed version will help remove some pressure on setups like ours where this plugin is mandatory for production. I'm sure it will be appreciated by many users.   
            arbeita Ronny Borchert added a comment - - edited

            Somehow this issue has been resolved by new jenkins version or plugins (except Tfs plugin) . Can anybody confirm?

            arbeita Ronny Borchert added a comment - - edited Somehow this issue has been resolved by new jenkins version or plugins (except Tfs plugin) . Can anybody confirm?

            arbeita Yes, I can confirm that issue has been resolved after upgrade to Jenkins 2.289.1 (plugins have been updated as well)

            heldain Mikhail Platonov added a comment - arbeita  Yes, I can confirm that issue has been resolved after upgrade to Jenkins 2.289.1 (plugins have been updated as well)
            caseydaniell Casey added a comment -

            I am confirming that this is fixed in 2.303.1 too. We can now upgrade our Jenkins instances to newer versions and keep using the (insecure, but mandatory and needed) TFS plugins.

            caseydaniell Casey added a comment - I am confirming that this is fixed in 2.303.1 too. We can now upgrade our Jenkins instances to newer versions and keep using the (insecure, but mandatory and needed) TFS plugins.
            glevy Gilad added a comment -

            Actually, it is totally broken on 2.303.1 because of the removal of Apache Commons Digester from the Jenkins core.
            https://www.jenkins.io/doc/upgrade-guide/2.303/

            I had to fix and build it locally to make it work.

            glevy Gilad added a comment - Actually, it is totally broken on 2.303.1 because of the removal of Apache Commons Digester from the Jenkins core. https://www.jenkins.io/doc/upgrade-guide/2.303/ I had to fix and build it locally to make it work.
            ianw Ian Williams added a comment -

            While it would seem MS has completely abandoned support for this plugin, the impact of "removal of Apache Commons Digester from the Jenkins core" should be a separate issue from this. glevy, could you raise a separate issue, and perhaps even a PR, or at least document any fixes you needed to address in the JIRA?

            Still hoping someone might step up to be a maintainer (and MS formally put it up for adoption).

            ianw Ian Williams added a comment - While it would seem MS has completely abandoned support for this plugin, the impact of "removal of Apache Commons Digester from the Jenkins core" should be a separate issue from this. glevy , could you raise a separate issue, and perhaps even a PR, or at least document any fixes you needed to address in the JIRA? Still hoping someone might step up to be a maintainer (and MS formally put it up for adoption).
            glevy Gilad added a comment - Thanks ianw , I found a related issue and added a link to my fix in a new comment: https://issues.jenkins.io/browse/JENKINS-65867?focusedCommentId=413483&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-413483

            People

              Unassigned Unassigned
              arbeita Ronny Borchert
              Votes:
              12 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

                Created:
                Updated: