Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64247

jabber plugin save problem on Jenkins >= 2.264

XMLWordPrintable

    • 1.41

      After jenkins 2.664, every maven and freestyle project with jabber plugin can't be saved. I received this message:

       

       

      Probably caused by table tags in https://github.com/jenkinsci/jabber-plugin/blob/ea1bc6d5e508b29f427d66131aa348b54d3609e7/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly 

        1. image-2020-11-17-12-43-37-421.png
          image-2020-11-17-12-43-37-421.png
          200 kB

          [JENKINS-64247] jabber plugin save problem on Jenkins >= 2.264

          Andre Crespo created issue -
          Tim Jacomb made changes -
          Labels New: tables-to-divs-regression
          Josh Soref made changes -
          Description Original: After jenkins 2.664, every maven and freestyle project with jabber plugin can't be saved. I received this message:

           

          !image-2020-11-17-12-43-37-421.png|width=535,height=287!           		New: After jenkins 2.664, every maven and freestyle project with jabber plugin can't be saved. I received this message:

           

          !image-2020-11-17-12-43-37-421.png|width=535,height=287!

           

          Probably caused by {{table}} tags in [https://github.com/jenkinsci/jabber-plugin/blob/ea1bc6d5e508b29f427d66131aa348b54d3609e7/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly] 

          Jim Klimov added a comment -

          Cheers flow : I am not sure if the issue and solution at https://github.com/jenkinsci/ircbot-plugin/pull/31 is the correct one for such problem, but if it passes the review - it probably applies neatly here. Codebases are way too related

          Jim Klimov added a comment - Cheers flow : I am not sure if the issue and solution at https://github.com/jenkinsci/ircbot-plugin/pull/31 is the correct one for such problem, but if it passes the review - it probably applies neatly here. Codebases are way too related

          Jim Klimov added a comment -

          Cheers, seems that change has fixed it - I published ircbot and instant-messaging-plugin so you can follow in the footsteps, the markup change is rather small and simple

          Jim Klimov added a comment - Cheers, seems that change has fixed it - I published ircbot and instant-messaging-plugin so you can follow in the footsteps, the markup change is rather small and simple

          Florian Schmaus added a comment -

          Thanks. I am not sure when I'll find the time for this, though. Any assistance in form of contributing a patch (or pull request) is greatly appreciated.

          Florian Schmaus added a comment - Thanks. I am not sure when I'll find the time for this, though. Any assistance in form of contributing a patch (or pull request) is greatly appreciated.

          Jim Klimov added a comment -

          Ok, posted https://github.com/jenkinsci/jabber-plugin/pull/24 for the first shot to fix the urgent problem of broken UI (presumably, per precedent with similar plugins).

          There is further work cleaning up those insecure oldskul input elements that timja is kindly doing in ircbot and instant-messaging-plugin, I linked to those PRs from mine, so you'd have easier time adapting those changes for jabber-plugin

          Jim Klimov added a comment - Ok, posted https://github.com/jenkinsci/jabber-plugin/pull/24 for the first shot to fix the urgent problem of broken UI (presumably, per precedent with similar plugins). There is further work cleaning up those insecure oldskul input elements that timja is kindly doing in ircbot and instant-messaging-plugin, I linked to those PRs from mine, so you'd have easier time adapting those changes for jabber-plugin
          Jim Klimov made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Mark Waite made changes -
          Summary Original: jabber plugin save problem on Jenkins >= 2.2664 New: jabber plugin save problem on Jenkins >= 2.264
          Florian Schmaus made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

            flow Florian Schmaus
            acrespo Andre Crespo
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: