-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
-
43.vea_da_7c53b_831
Hello,
I'd like to enhance the docs of this plugin and create a PR for that.
However, I've realized that there is a naming inconsistency between GitHub and Bitbucket which is super confusing.
- In GitHub, the trait is called 'notificationsSkip'.
https://github.com/jenkinsci/skip-notifications-trait-plugin/blob/ffaa9a99b850ec84a20372150acd735a80016bb2/src/main/java/org/jenkinsci/plugins/github/notifications/NotificationsSkipTrait.java#L66 - In Bitbucket, the trait is called 'skipNotifications'.
https://github.com/jenkinsci/skip-notifications-trait-plugin/blob/ffaa9a99b850ec84a20372150acd735a80016bb2/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/notifications/SkipNotificationsTrait.java#L59
Not sure if that intended or there are any constraints that force that naming inconsistency.
Thanks