• Type: Bug
• Resolution: Unresolved
• Priority: Major
• Component/s: gerrit-trigger-plugin
• Labels:

  None

[JENKINS-64372] "Comment added" based triggers broken since Gerrit 3.3

Vitaliy Lotorev created issue - 2020-12-05 21:30

Vitaliy Lotorev made changes - 2020-12-05 21:32

Description

Original: Starting from Gerrit 3.3.0 messages sent via Reply dialog are posted as Patchset level comments (instead of Change messages), see [1-2]. It seems like a breaking change in Gerrit behaviour. gerrit-trigger-plugin doesn't support such Patchset level comments. [1] https://gerrit-review.googlesource.com/c/gerrit/+/266176 [2] https://gerrit-review.googlesource.com/c/homepage/+/288131

New: Starting from Gerrit 3.3.0 messages sent via Reply dialog are posted as Patchset level comments (instead of Change messages), see [1-2]. It seems like a breaking change in Gerrit behaviour. gerrit-trigger-plugin doesn't support such Patchset level comments, so posting comments via Gerrit web UI triggered Jenkins jobs in Gerrit 3.2 and stopped triggering in Gerrit 3.3. [1] https://gerrit-review.googlesource.com/c/gerrit/+/266176 [2] https://gerrit-review.googlesource.com/c/homepage/+/288131

Vitaliy Lotorev made changes - 2020-12-05 21:32

Description

Original: Starting from Gerrit 3.3.0 messages sent via Reply dialog are posted as Patchset level comments (instead of Change messages), see [1-2]. It seems like a breaking change in Gerrit behaviour. gerrit-trigger-plugin doesn't support such Patchset level comments, so posting comments via Gerrit web UI triggered Jenkins jobs in Gerrit 3.2 and stopped triggering in Gerrit 3.3. [1] https://gerrit-review.googlesource.com/c/gerrit/+/266176 [2] https://gerrit-review.googlesource.com/c/homepage/+/288131

New: Starting from Gerrit 3.3.0 messages sent via Reply dialog are posted as Patchset level comments (instead of Change messages), see [1-2]. It seems like a breaking change in Gerrit behaviour. gerrit-trigger-plugin doesn't support such Patchset level comments, so posting comments via Gerrit web UI is triggering Jenkins jobs in Gerrit 3.2 and is not triggering in Gerrit 3.3. [1] https://gerrit-review.googlesource.com/c/gerrit/+/266176 [2] https://gerrit-review.googlesource.com/c/homepage/+/288131

Collapse comment: George Joseph added a comment - 2020-12-11 17:13

George Joseph added a comment - 2020-12-11 17:13

Just ran across the same issue. I'd classify this as a bug not a new feature.

Expand comment: George Joseph added a comment - 2020-12-11 17:13

George Joseph added a comment - 2020-12-11 17:13 Just ran across the same issue. I'd classify this as a bug not a new feature.

George Joseph made changes - 2020-12-11 17:13

Issue Type

Original: New Feature [ 2 ]

New: Bug [ 1 ]

Jerome Oufella made changes - 2021-01-20 17:16

Summary

Original: Support for patchset level comments

New: "Comment added" based triggers broken since Gerrit 3.3

Collapse comment: Jerome Oufella added a comment - 2021-04-15 17:05

Jerome Oufella added a comment - 2021-04-15 17:05

Note: Gerrit configuration option event.comment-added.publishPatchSetLevelComment introduced in Gerrit 3.3.1 allows restoring the pre-3.3 behavior and thus working around this issue.

Expand comment: Jerome Oufella added a comment - 2021-04-15 17:05

Jerome Oufella added a comment - 2021-04-15 17:05 Note: Gerrit configuration option event.comment-added.publishPatchSetLevelComment introduced in Gerrit 3.3.1 allows restoring the pre-3.3 behavior and thus working around this issue.