Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64435

Running build logs have a different font size than finished build logs

XMLWordPrintable

    • 2.338

        1. this is just silly.png
          this is just silly.png
          138 kB
        2. Screenshot 2022-03-05 at 10.45.37.png
          Screenshot 2022-03-05 at 10.45.37.png
          231 kB
        3. Screenshot 2020-12-14 at 00.00.43.png
          Screenshot 2020-12-14 at 00.00.43.png
          2.71 MB

          [JENKINS-64435] Running build logs have a different font size than finished build logs

          Daniel Beck created issue -

          Daniel Beck added a comment - - edited

          While the additional nested element existed in Jenkins 2.225, the font size was the same. It is different in 2.226, indicating https://github.com/jenkinsci/jenkins/commit/56bce19cd6e26a4e122f761cb6fd3baf47a870e1 caused this to break.

          Perhaps fqueiruga knows enough about the progressiveText insanity to safely get rid of the extra level of nesting?

          Daniel Beck added a comment - - edited While the additional nested element existed in Jenkins 2.225, the font size was the same. It is different in 2.226, indicating https://github.com/jenkinsci/jenkins/commit/56bce19cd6e26a4e122f761cb6fd3baf47a870e1 caused this to break. Perhaps fqueiruga knows enough about the progressiveText insanity to safely get rid of the extra level of nesting?
          Daniel Beck made changes -
          Attachment New: Screenshot 2020-12-14 at 00.00.43.png [ 53593 ]

          Daniel Beck added a comment -

          I cannot manage to upload the other screenshot, Jira errors out. It looks pretty much like this one, just different font size

          Daniel Beck added a comment - I cannot manage to upload the other screenshot, Jira errors out. It looks pretty much like this one, just different font size
          Daniel Beck made changes -
          Labels Original: ui ux New: regression ui ux

          Félix Queiruga Balado added a comment -

          Homogeinizing the font sizes was tough, especially when dealing with monospaced elements, such as <pre>. This one probably slipped. Probably a missing rule somewhere.

          Félix Queiruga Balado added a comment - Homogeinizing the font sizes was tough, especially when dealing with monospaced elements, such as <pre>. This one probably slipped. Probably a missing rule somewhere.
          Félix Queiruga Balado made changes -
          Epic Link New: JENKINS-60919 [ 204316 ]

          Daniel Beck added a comment -

          fqueiruga Looks at the screenshot, there are two nested pre in a running build. This only applies to running builds.

          This didn't matter until 2.226, when you defined font-size: 0.95em; for pre, so each nested pre reduces font size by 5%.

          Daniel Beck added a comment - fqueiruga Looks at the screenshot, there are two nested  pre in a running build. This only applies to running builds. This didn't matter until 2.226, when you defined font-size: 0.95em; for pre , so each nested pre reduces font size by 5%.

          Félix Queiruga Balado added a comment -

          then maybe the solution can be something like 

           pre pre { font-size: 1em; }

          Félix Queiruga Balado added a comment - then maybe the solution can be something like  pre pre { font-size: 1em; }

          Daniel Beck added a comment -

          Sure, or even pre#out.console-output pre but that's just a workaround.

          The real problem IMO is the additional level of nesting that doesn't seem correct; but id didn't have a visual impact before your style changes. This is the reason I suggest we fix progressiveText.jelly possibly by just ripping out the IE workaround.

          Daniel Beck added a comment - Sure, or even pre#out.console-output pre but that's just a workaround. The real problem IMO is the additional level of nesting that doesn't seem correct; but id didn't have a visual impact before your style changes. This is the reason I suggest we fix progressiveText.jelly possibly by just ripping out the IE workaround.

            notmyfault Alexander Brandes
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: