[JENKINS-64438] java.lang.UnsupportedOperationException in RecordIssuesStep

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: core, warnings-ng-plugin, workflow-api-plugin
Labels:
None
Environment:

Hide
Jenkins 2.249.3
warnings-ng-plugin 8.4.4
idea 2020.1
ideaSHA256 fa301279ec1591ecad8758113ff22a64e82b11a583e7eae6fac0eb60ddc9f8e5
openjdk version "1.8.0_272"
OpenJDK Runtime Environment (build 1.8.0_272-8u272-b10-0+deb9u1-b10)
OpenJDK 64-Bit Server VM (build 25.272-b10, mixed mode)

Show
Jenkins 2.249.3 warnings-ng-plugin 8.4.4 idea 2020.1 ideaSHA256 fa301279ec1591ecad8758113ff22a64e82b11a583e7eae6fac0eb60ddc9f8e5 openjdk version "1.8.0_272" OpenJDK Runtime Environment (build 1.8.0_272-8u272-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.272-b10, mixed mode)

Similar Issues:
Powered by SuggestiMate

Show
Released As:
workflow-api 2.41

While recording ideaInspection, we get the following exception:

java.lang.UnsupportedOperationException
	at java.util.concurrent.CopyOnWriteArrayList$COWIterator.remove(CopyOnWriteArrayList.java:1182)
	at java.util.AbstractCollection.removeAll(AbstractCollection.java:376)
	at hudson.model.Actionable.addOrReplaceAction(Actionable.java:209)
	at io.jenkins.plugins.analysis.core.util.PipelineResultHandler.setResult(PipelineResultHandler.java:34)
	at io.jenkins.plugins.analysis.core.steps.IssuesPublisher.attachAction(IssuesPublisher.java:120)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:721)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

The pipeline code:

recordIssues(
	failOnError: true,
	enabledForFailure: true,
	ignoreFailedBuilds: false,
	qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]],
	tools: [
		ideaInspection(pattern: 'idea-inspection-output/**'),
	],
)

This is identical in all projects. It is not related to the specific inspection result itself, as long as a failing inspection is reported. Projects without inspection errors will be a success.

Please find attached a minimal example. Disabling failOnError will make the sample running. The only errors I see in my logs are:

[IntelliJ IDEA Inspections] [-ERROR-] Can't create fingerprints for some files:
[IntelliJ IDEA Inspections] [-ERROR-] - '$PROJECT_DIR$/testsrc/com/example/ExampleTest.java', IO exception has been thrown: java.nio.file.NoSuchFileException: $PROJECT_DIR$/testsrc/com/example/ExampleTest.java

I'm not sure if this is related to the exception, but even if this is handled as an error in the sense of failOnError, there should be no exception.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

minimal.zip
1 kB
2020-12-14 10:37

is duplicated by

JENKINS-64511 Unable to replace action in StepAtomNode

Open

links to

PR #133

Martin Heinzerling created issue - 2020-12-14 10:11

Martin Heinzerling made changes - 2020-12-14 10:13

Description

Original: While recording ideaInspection, we get the following exception:
{code:java}
java.lang.UnsupportedOperationException
at java.util.concurrent.CopyOnWriteArrayList$COWIterator.remove(CopyOnWriteArrayList.java:1182)
at java.util.AbstractCollection.removeAll(AbstractCollection.java:376)
at hudson.model.Actionable.addOrReplaceAction(Actionable.java:209)
at io.jenkins.plugins.analysis.core.util.PipelineResultHandler.setResult(PipelineResultHandler.java:34)
at io.jenkins.plugins.analysis.core.steps.IssuesPublisher.attachAction(IssuesPublisher.java:120)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:721)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}

The pipeline code:

{code}
recordIssues(
failOnError: true,
enabledForFailure: true,
ignoreFailedBuilds: false,
qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]],
tools: [
ideaInspection(pattern: 'idea-inspection-output/**'),
],
)
{code}

This is identical in all projects. It is not related to the specific inspection result itself, as long as a failing exception is reported. Projects without inspection errors will be a success.

New: While recording ideaInspection, we get the following exception:
{code:java}
java.lang.UnsupportedOperationException
at java.util.concurrent.CopyOnWriteArrayList$COWIterator.remove(CopyOnWriteArrayList.java:1182)
at java.util.AbstractCollection.removeAll(AbstractCollection.java:376)
at hudson.model.Actionable.addOrReplaceAction(Actionable.java:209)
at io.jenkins.plugins.analysis.core.util.PipelineResultHandler.setResult(PipelineResultHandler.java:34)
at io.jenkins.plugins.analysis.core.steps.IssuesPublisher.attachAction(IssuesPublisher.java:120)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:721)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}

The pipeline code:

{code}
recordIssues(
failOnError: true,
enabledForFailure: true,
ignoreFailedBuilds: false,
qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]],
tools: [
ideaInspection(pattern: 'idea-inspection-output/**'),
],
)
{code}

This is identical in all projects. It is not related to the specific inspection result itself, as long as a failing inspection is reported. Projects without inspection errors will be a success.

Martin Heinzerling made changes - 2020-12-14 10:18

Environment

Original: Jenkins 2.249.3
warnings-ng-plugin 8.4.4

New: Jenkins 2.249.3
warnings-ng-plugin 8.4.4
idea 2020.1
ideaSHA256 fa301279ec1591ecad8758113ff22a64e82b11a583e7eae6fac0eb60ddc9f8e5

Martin Heinzerling made changes - 2020-12-14 10:37

Attachment

New: minimal.zip [ 53595 ]

Martin Heinzerling made changes - 2020-12-14 10:43

Description

Original: While recording ideaInspection, we get the following exception:
{code:java}
java.lang.UnsupportedOperationException
at java.util.concurrent.CopyOnWriteArrayList$COWIterator.remove(CopyOnWriteArrayList.java:1182)
at java.util.AbstractCollection.removeAll(AbstractCollection.java:376)
at hudson.model.Actionable.addOrReplaceAction(Actionable.java:209)
at io.jenkins.plugins.analysis.core.util.PipelineResultHandler.setResult(PipelineResultHandler.java:34)
at io.jenkins.plugins.analysis.core.steps.IssuesPublisher.attachAction(IssuesPublisher.java:120)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:721)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}

The pipeline code:

{code}
recordIssues(
failOnError: true,
enabledForFailure: true,
ignoreFailedBuilds: false,
qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]],
tools: [
ideaInspection(pattern: 'idea-inspection-output/**'),
],
)
{code}

This is identical in all projects. It is not related to the specific inspection result itself, as long as a failing inspection is reported. Projects without inspection errors will be a success.

New: While recording ideaInspection, we get the following exception:

{code:java}
java.lang.UnsupportedOperationException
at java.util.concurrent.CopyOnWriteArrayList$COWIterator.remove(CopyOnWriteArrayList.java:1182)
at java.util.AbstractCollection.removeAll(AbstractCollection.java:376)
at hudson.model.Actionable.addOrReplaceAction(Actionable.java:209)
at io.jenkins.plugins.analysis.core.util.PipelineResultHandler.setResult(PipelineResultHandler.java:34)
at io.jenkins.plugins.analysis.core.steps.IssuesPublisher.attachAction(IssuesPublisher.java:120)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.publishResult(IssuesRecorder.java:721)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:651)
at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:1024)
at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:985)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}

The pipeline code:

{code}
recordIssues(
failOnError: true,
enabledForFailure: true,
ignoreFailedBuilds: false,
qualityGates: [[threshold: 1, type: 'TOTAL', unstable: true]],
tools: [
ideaInspection(pattern: 'idea-inspection-output/**'),
],
)
{code}

This is identical in all projects. It is not related to the specific inspection result itself, as long as a failing inspection is reported. Projects without inspection errors will be a success.

Please find attached a minimal example. Disabling failOnError will make the sample running. The only errors I see in my logs are:
{code}
[IntelliJ IDEA Inspections] [-ERROR-] Can't create fingerprints for some files:
[IntelliJ IDEA Inspections] [-ERROR-] - '$PROJECT_DIR$/testsrc/com/example/ExampleTest.java', IO exception has been thrown: java.nio.file.NoSuchFileException: $PROJECT_DIR$/testsrc/com/example/ExampleTest.java
{code}

I'm not sure if this is related to the exception, but even if this is handled as an error in the sense of failOnError, there should be no exception.

Ulli Hafner added a comment - 2020-12-14 10:46

Has anyone an idea what happens here in Actionable? The actions are of type CopyOnWriteArrayList but this list does implement remove.

Ulli Hafner added a comment - 2020-12-14 10:46 Has anyone an idea what happens here in Actionable ? The actions are of type CopyOnWriteArrayList but this list does implement remove .

Ulli Hafner made changes - 2020-12-14 10:46

Component/s		New: core [ 15593 ]
Assignee	Original: Ulli Hafner [ drulli ]

Raihaan Shouhell added a comment - 2020-12-14 13:10 - edited

Might be because its unmodifiable https://github.com/jenkinsci/jenkins/blob/f7884d3513c6e436baef432a486197a3bb4d846c/core/src/main/java/hudson/model/AbstractProject.java#L985

EDIT: Closer inspection seems to show that FlowNode the function being called from a FlowNode, perhaps a FlowNode's getActions() returns an unmodifiable list like above

Raihaan Shouhell added a comment - 2020-12-14 13:10 - edited Might be because its unmodifiable https://github.com/jenkinsci/jenkins/blob/f7884d3513c6e436baef432a486197a3bb4d846c/core/src/main/java/hudson/model/AbstractProject.java#L985 EDIT: Closer inspection seems to show that FlowNode the function being called from a FlowNode, perhaps a FlowNode's getActions() returns an unmodifiable list like above

Ulli Hafner added a comment - 2020-12-14 13:30

I don't think that this is the problem, the getActions() method is implemented in Actionable and not in AbstractProject. This is the method that has been called: https://github.com/jenkinsci/jenkins/blob/f7884d3513c6e436baef432a486197a3bb4d846c/core/src/main/java/hudson/model/Actionable.java#L76

Ulli Hafner added a comment - 2020-12-14 13:30 I don't think that this is the problem, the getActions() method is implemented in Actionable and not in AbstractProject . This is the method that has been called: https://github.com/jenkinsci/jenkins/blob/f7884d3513c6e436baef432a486197a3bb4d846c/core/src/main/java/hudson/model/Actionable.java#L76

Ulli Hafner added a comment - 2020-12-14 13:30

mheinzerling Which JRE are you using to run Jenkins?

Ulli Hafner added a comment - 2020-12-14 13:30 mheinzerling Which JRE are you using to run Jenkins?

Assignee:: Bill Collins

Reporter:: Martin Heinzerling

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 2020-12-14 10:11

Updated:: 2021-01-20 18:43

Resolved:: 2021-01-11 17:35

Jenkins

Details

Description

Attachments

Attachments

Issue Links

Activity

Collapse comment: Ulli Hafner added a comment - 2020-12-14 10:46

Expand comment: Ulli Hafner added a comment - 2020-12-14 10:46

Collapse comment: Raihaan Shouhell added a comment - 2020-12-14 13:10, Edited by Raihaan Shouhell - 2020-12-14 13:24

Expand comment: Raihaan Shouhell added a comment - 2020-12-14 13:10, Edited by Raihaan Shouhell - 2020-12-14 13:24

Collapse comment: Ulli Hafner added a comment - 2020-12-14 13:30

Expand comment: Ulli Hafner added a comment - 2020-12-14 13:30

Collapse comment: Ulli Hafner added a comment - 2020-12-14 13:30

Expand comment: Ulli Hafner added a comment - 2020-12-14 13:30

People

Dates