Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64547

AdministrativeMonitors should first check if a monitor is enabled

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: support-core-plugin
    • Labels:
      None
    • Environment:
      support-core:2.2
    • Similar Issues:
    • Released As:
      support-core-2.74

      Description

      The AdministrativeMonitors component checks if a monitor is activated before checking if it is enabled: https://github.com/jenkinsci/support-core-plugin/blob/support-core-2.72/src/main/java/com/cloudbees/jenkins/support/impl/AdministrativeMonitors.java#L67

      This causes unnecessary load. Some monitor implementation of isActivated contains loops and certain complexity.

      The component should first check if the monitor is enabled and if it is, then only it should check if it is activated.

        Attachments

          Activity

          There are no comments yet on this issue.

            People

            Assignee:
            allan_burdajewicz Allan BURDAJEWICZ
            Reporter:
            allan_burdajewicz Allan BURDAJEWICZ
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: