• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • Jenkins 2.249.3
    • 2.277, 2.263.4, and 2.277.1

      I believe that with JENKINS-62345, as there is only one point to create the fingerprint files on the disk, and that method is synchronized, we created the context to limit the number of fingerprint we can save on disk.

      This is a big performance issue when used with Maven plugin and a set of jobs with multiple modules. It creates a queue of fingerprint objects, waiting for the lock on the FileFingerprintStorage.

          [JENKINS-64670] FileFingerprintStorage performance

          Adrien Lecharpentier created issue -
          Adrien Lecharpentier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Adrien Lecharpentier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Adrien Lecharpentier made changes -
          Assignee New: Adrien Lecharpentier [ alecharp ]

          alecharp are you aware of any stack trace in thread dumps showing this slowness' hypothesis? Merci  !

          Baptiste Mathus added a comment - alecharp  are you aware of any stack trace in thread dumps showing this slowness' hypothesis? Merci  !

          Allan BURDAJEWICZ added a comment - - edited

          One thread holds a lock on the FileFingerprintStorage

          	at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:126)
          	- locked <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          

          Many others are BLOCKED waiting for the resource:

          	at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:125)
          	- waiting to lock <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          

          Allan BURDAJEWICZ added a comment - - edited One thread holds a lock on the FileFingerprintStorage at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:126) - locked <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage) Many others are BLOCKED waiting for the resource: at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:125) - waiting to lock <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          Adrien Lecharpentier made changes -
          Labels New: lts
          Adrien Lecharpentier made changes -
          Labels Original: lts New: lts-candidate
          Mark Waite made changes -
          Released As New: 2.277
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          Mark Waite made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            alecharp Adrien Lecharpentier
            alecharp Adrien Lecharpentier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: