Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64700

Restriction on label name

XMLWordPrintable

      Hi,

      I just upgraded Jenkins from 2.249.2 to 2.263.2, then I have some build job take a long time to start a build, regarding the log below, I foundout that this is restriction on label name.

       

      2021-01-25 03:14:58.396+0000 [id=55]    SEVERE  hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent ecsaws-ecs1||ecs2||ecs3||ecs4||ecs5-hmll4
hudson.model.Failure: ‘|’ is an unsafe character
        at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4029)
        at jenkins.model.Nodes.addNode(Nodes.java:139)
        at jenkins.model.Jenkins.addNode(Jenkins.java:2157)
        at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256)
        at hudson.model.Queue._withLock(Queue.java:1398)
        at hudson.model.Queue.withLock(Queue.java:1275)
        at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225)
        at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64)
        at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823)
        at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91)
        at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

      I set the node label in build job as below

      So I went to "Script Console" and run command: System.setProperty("hudson.model.LabelAtom.allowFolderTraversal", "true") , also tried to Reload Configuration from Disk, but the issue still occur. I'm using ECS plugin for dynamic slave.

      Something wrong or what might causing the issue?

       

        1. image-2021-02-24-18-34-47-425.png
          image-2021-02-24-18-34-47-425.png
          75 kB

          [JENKINS-64700] Restriction on label name

          Dennis Tran created issue -
          Dennis Tran made changes -
          Component/s New: ecs-publisher-plugin [ 23058 ]
          Description Original: Hi,

          I just upgraded Jenkins from 2.249.2 to 2.263.2, then I have some build job take a long time to start a build, regarding the log below, I foundout that this is restriction on label name.

           
          {code:java}
          2021-01-25 03:14:58.396+0000 [id=55] SEVERE hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent ecsaws-ecs1||ecs2||ecs3||ecs4||ecs5-hmll4
          hudson.model.Failure: ‘|’ is an unsafe character
                  at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4029)
                  at jenkins.model.Nodes.addNode(Nodes.java:139)
                  at jenkins.model.Jenkins.addNode(Jenkins.java:2157)
                  at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256)
                  at hudson.model.Queue._withLock(Queue.java:1398)
                  at hudson.model.Queue.withLock(Queue.java:1275)
                  at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225)
                  at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64)
                  at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823)
                  at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91)
                  at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                  at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                  at java.lang.Thread.run(Thread.java:748)

          {code}
          So I went to "Script Console" and run command: System.setProperty("hudson.model.LabelAtom.allowFolderTraversal", "true") , also tried to Reload Configuration from Disk, but the issue still occur.

          Something wrong or what might causing the issue?

                      		New: Hi,

          I just upgraded Jenkins from 2.249.2 to 2.263.2, then I have some build job take a long time to start a build, regarding the log below, I foundout that this is restriction on label name.

           
          {code:java}
          2021-01-25 03:14:58.396+0000 [id=55] SEVERE hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent ecsaws-ecs1||ecs2||ecs3||ecs4||ecs5-hmll4
          hudson.model.Failure: ‘|’ is an unsafe character
                  at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4029)
                  at jenkins.model.Nodes.addNode(Nodes.java:139)
                  at jenkins.model.Jenkins.addNode(Jenkins.java:2157)
                  at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256)
                  at hudson.model.Queue._withLock(Queue.java:1398)
                  at hudson.model.Queue.withLock(Queue.java:1275)
                  at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225)
                  at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64)
                  at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823)
                  at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91)
                  at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                  at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                  at java.lang.Thread.run(Thread.java:748)

          {code}
          So I went to "Script Console" and run command: System.setProperty("hudson.model.LabelAtom.allowFolderTraversal", "true") , also tried to Reload Configuration from Disk, but the issue still occur. I'm using ECS plugin for dynamic slave.

          Something wrong or what might causing the issue?

           
          Labels Original: slave-agent New: ECS slave-agent

          Dennis Tran added a comment -

          This issue still occur in version 2.263.4, any idea?

           

          Dennis Tran added a comment - This issue still occur in version 2.263.4, any idea?  
          Dennis Tran made changes -
          Attachment New: image-2021-02-24-18-34-47-425.png [ 54040 ]
          Description Original: Hi,

          I just upgraded Jenkins from 2.249.2 to 2.263.2, then I have some build job take a long time to start a build, regarding the log below, I foundout that this is restriction on label name.

           
          {code:java}
          2021-01-25 03:14:58.396+0000 [id=55] SEVERE hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent ecsaws-ecs1||ecs2||ecs3||ecs4||ecs5-hmll4
          hudson.model.Failure: ‘|’ is an unsafe character
                  at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4029)
                  at jenkins.model.Nodes.addNode(Nodes.java:139)
                  at jenkins.model.Jenkins.addNode(Jenkins.java:2157)
                  at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256)
                  at hudson.model.Queue._withLock(Queue.java:1398)
                  at hudson.model.Queue.withLock(Queue.java:1275)
                  at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225)
                  at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64)
                  at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823)
                  at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91)
                  at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                  at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                  at java.lang.Thread.run(Thread.java:748)

          {code}
          So I went to "Script Console" and run command: System.setProperty("hudson.model.LabelAtom.allowFolderTraversal", "true") , also tried to Reload Configuration from Disk, but the issue still occur. I'm using ECS plugin for dynamic slave.

          Something wrong or what might causing the issue?

                      		New: Hi,

          I just upgraded Jenkins from 2.249.2 to 2.263.2, then I have some build job take a long time to start a build, regarding the log below, I foundout that this is restriction on label name.

           
          {code:java}
          2021-01-25 03:14:58.396+0000 [id=55] SEVERE hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent ecsaws-ecs1||ecs2||ecs3||ecs4||ecs5-hmll4
          hudson.model.Failure: ‘|’ is an unsafe character
                  at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4029)
                  at jenkins.model.Nodes.addNode(Nodes.java:139)
                  at jenkins.model.Jenkins.addNode(Jenkins.java:2157)
                  at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256)
                  at hudson.model.Queue._withLock(Queue.java:1398)
                  at hudson.model.Queue.withLock(Queue.java:1275)
                  at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225)
                  at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64)
                  at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823)
                  at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91)
                  at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                  at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
                  at java.lang.Thread.run(Thread.java:748)

          {code}
          I set the node label in build job as below

          !image-2021-02-24-18-34-47-425.png!

          So I went to "Script Console" and run command: System.setProperty("hudson.model.LabelAtom.allowFolderTraversal", "true") , also tried to Reload Configuration from Disk, but the issue still occur. I'm using ECS plugin for dynamic slave.

          Something wrong or what might causing the issue?

           

          Raihaan Shouhell added a comment -

          The problem here is that your cloud might be provisioning a node with the | character in it, which is illegal

          Raihaan Shouhell added a comment - The problem here is that your cloud might be provisioning a node with the | character in it, which is illegal

            Unassigned Unassigned
            tiendungitd Dennis Tran
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: