-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
I'm using the automatic POD_LABEL generated since JENKINS-57830 very successfully. I have one minor gripe with it: When building branches/tags from a multibranch pipeline, the branch/tag name often ends up in the generated POD_LABEL (which is nice), but those sometimes contain dots (release/1.22.x or 1.22.5). Since this is also used as the pod name, the hostname ends up with a dot in it, which seems... weird to me... (Additionally, this caused a spurious test failure in one of our projects which assumes that the hostname does, in fact, NOT contain any dots ).
I'd suggest to remove the dot from the "allowed" characters when creating a random label: https://github.com/jenkinsci/kubernetes-plugin/blob/09bcc70d1c240f6ee6d32b1fdc358e5d3a04c139/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java#L184
WDYT?