Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: ircbot-plugin
-
Labels:None
-
Environment:rhel 5.3 64-bit
hudson 1.351
im plugin 1.7
irc plugin 2.3
-
Similar Issues:
Description
Sometimes the irc bot sends command output to the wrong irc user.
For example, if I send the hudson bot the command "!help" (with ! being the command prefix), sometimes I get the output.
But then, if another irc user sends the hudson bot the command "!help", then that other user might get the output, or I might get the output (incorrectly). I haven't been able to identify a pattern to when hudson gets it correct, versus incorrect.
Attachments
Activity
Yeah, I think I've found the bug. Seems that this was broken from the beginning, so thanks for pointing this out.
It would be great if you could test that the attached snapshot build fixes your problem.
kutzi
added a comment - Yeah, I think I've found the bug. Seems that this was broken from the beginning, so thanks for pointing this out.
It would be great if you could test that the attached snapshot build fixes your problem. Code changed in hudson
User: : kutzi
Path:
trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java
trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/PircConnection.java
http://jenkins-ci.org/commit/30950
Log:
[FIXED JENKINS-6484] ircbot command output send to wrong user
Can you try to issue some invalid commands - e.g. !status invalidjobname - and see what the bot sends as reply in case the output goes to the wrong user.
It should ouptut:
"<sender>: unknown job 'invalidjobname'"
kutzi
added a comment - Can you try to issue some invalid commands - e.g. !status invalidjobname - and see what the bot sends as reply in case the output goes to the wrong user.
It should ouptut:
"<sender>: unknown job 'invalidjobname'" Both people initiated the commands in a private message to the bot.
The output is not duplicated. It only goes to one person.
philsttr
added a comment - Both people initiated the commands in a private message to the bot.
The output is not duplicated. It only goes to one person. 
Finally got a chance to try this. It looks like build you provided is working now. Thanks!