Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65071

Closing a github PR should not trigger tags examination

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I started to notice that our github app key quota gets exhausted. When this happens usually is because Jenkins is doing a full examination of the repository, and since I have a lot of tags (2k+), this process takes a while (10mins) and depletes the quota.

      From checking the Multibranch Pipeline Events logs I can see that tags are being processed, but usually it is hard to understand what triggered this. However today I managed to reproduce this by closing a PR (not merging). Here are the logs

       

       

      [Wed Mar 10 11:55:06 UTC 2021] Received Pull request #16349 closed in repository xxx/platform REMOVED event from 140.82.115.242 ⇒ https://jenkins.xxxx.com/github-webhook/ with timestamp Wed Mar 10 11:55:01 UTC 2021
      11:55:06 GitHub throttling is disabled, which is not allowed for public GitHub usage, so ThrottleOnOver will be used instead. To configure a different rate limiting strategy, go to "GitHub API usage" under "Configure System" in the Jenkins settings.
      11:55:06 Connecting to https://api.github.com using 88560/****** (GitHub app key)
      [Wed Mar 10 11:55:06 UTC 2021] Received Pull request #16349 closed in repository xxx/platform REMOVED event from 140.82.115.155 ⇒ https://jenkins.xxx.com/github-webhook/ with timestamp Wed Mar 10 11:55:01 UTC 2021
      11:55:06 GitHub throttling is disabled, which is not allowed for public GitHub usage, so ThrottleOnOver will be used instead. To configure a different rate limiting strategy, go to "GitHub API usage" under "Configure System" in the Jenkins settings.
      11:55:06 Connecting to https://api.github.com using 88560/****** (GitHub app key)
      Examining xxx/platform
      
        Checking branches...
      
        Getting remote branch feature/joao_xxx...
      
          Checking branch feature/joao_xxx
      
        1 branches were processed
      
        Checking pull-requests...
      
        Getting remote pull request #16349...
      
      Examining xxx/platform
      
        Checking branches...
      
        Getting remote branch feature/joao_xxx...
      
          Checking branch feature/joao_xxx
      
        1 branches were processed
      
        Checking pull-requests...
      
        Getting remote pull request #16349...
      
        0 pull requests were processed
      
        Checking tags...
      
        Getting remote tags...
      
          Checking tag v0.1.0.0
      
          Checking tag v0.1.1.0
      
        0 pull requests were processed
      
        Checking tags...
      
        Getting remote tags...
      
          Checking tag v0.1.1.1
      
          Checking tag v0.1.2.0
      
          Checking tag v0.1.0.0
      
          Checking tag v0.1.1.0
      
          Checking tag v0.1.3.0

       

      Something which is also weird is that 2 webhooks were received triggering the examination twice, but maybe that is another problem. Is this something by design? I mean does jenkins really need to check the tags? If yes, maybe this could be configurable?

       

      UPDATE: reopening the PR also triggers the tags examination

        Attachments

          Activity

          Hide
          atcarmo André Carmo added a comment -

          We have here an attempt to fix the problem: https://github.com/jenkinsci/github-branch-source-plugin/pull/407

          Show
          atcarmo André Carmo added a comment - We have here an attempt to fix the problem:  https://github.com/jenkinsci/github-branch-source-plugin/pull/407
          Hide
          atcarmo André Carmo added a comment -

          The same happens to me. In fact every processed webhook from a PR seems to be checking all repo tags for no apparent reason.

          Show
          atcarmo André Carmo added a comment - The same happens to me. In fact every processed webhook from a PR seems to be checking all repo tags for no apparent reason.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            jtjeferreira Joao
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: