Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65270

Assessment not marking stage as failed and failing pipeline

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • rapid7-insightvm-container-assessment-plugin
    • None

      In a declarative pipeline I have a stage which submits 2 container images for assessment. If the threshold rule for vulnerabilities is met the pipeline is marked as failed. however, the step and stage still show as successful. The stage does not fail and the pipeline continues. When an assessment fails, both the step and stage should be marked as failed. The pipeline should stop and also marked as failed. Currently this does not happen.

      Here is the stage:

      stage('Assess') {
	steps {
		echo '=========== ^^^^^^^^^^^^ Assessing images...'
		script {
			assessContainerImage failOnPluginError: true,
				imageId: "${env.imageIdApi}",
				thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
				nameRules: []
			assessContainerImage failOnPluginError: true,
				imageId: "${env.imageIdUi}",
				thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
				nameRules: []
		}
	}
}

      And the resulting pipeline run:

        1. pipeline-screenshot-1.png
          pipeline-screenshot-1.png
          114 kB

          [JENKINS-65270] Assessment not marking stage as failed and failing pipeline

          Jonathan Whitby created issue -
          Jonathan Whitby made changes -
          Attachment Original: image-2021-03-31-11-19-59-645.png [ 54393 ]
          Jonathan Whitby made changes -
          Description Original: In a declarative pipeline I have a stage which submits 2 container images for assessment. If the threshold rule for vulnerabilities is met the pipeline is marked as failed. however, the step and stage still show as successful. The stage does not fail and the pipeline continues. When an assessment fails, both the step and stage should be marked as failed. The pipeline should stop and also marked as failed. Currently this does not happen.

          Here is the stage:
          {code:java}
          stage('Assess') {
          steps {
          echo '=========== ^^^^^^^^^^^^ Assessing images...'
          script {
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdApi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdUi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          }
          }
          }
          {code}

          And the resulting pipeline run:
           !image-2021-03-31-11-19-59-645.png|thumbnail!           		New: In a declarative pipeline I have a stage which submits 2 container images for assessment. If the threshold rule for vulnerabilities is met the pipeline is marked as failed. however, the step and stage still show as successful. The stage does not fail and the pipeline continues. When an assessment fails, both the step and stage should be marked as failed. The pipeline should stop and also marked as failed. Currently this does not happen.

          Here is the stage:
          {code:java}
          stage('Assess') {
          steps {
          echo '=========== ^^^^^^^^^^^^ Assessing images...'
          script {
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdApi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdUi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          }
          }
          }
          {code}

          And the resulting pipeline run:
          Jonathan Whitby made changes -
          Attachment New: pipeline-screenshot-1.png [ 54394 ]
          Jonathan Whitby made changes -
          Description Original: In a declarative pipeline I have a stage which submits 2 container images for assessment. If the threshold rule for vulnerabilities is met the pipeline is marked as failed. however, the step and stage still show as successful. The stage does not fail and the pipeline continues. When an assessment fails, both the step and stage should be marked as failed. The pipeline should stop and also marked as failed. Currently this does not happen.

          Here is the stage:
          {code:java}
          stage('Assess') {
          steps {
          echo '=========== ^^^^^^^^^^^^ Assessing images...'
          script {
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdApi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdUi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          }
          }
          }
          {code}

          And the resulting pipeline run:
          		New: In a declarative pipeline I have a stage which submits 2 container images for assessment. If the threshold rule for vulnerabilities is met the pipeline is marked as failed. however, the step and stage still show as successful. The stage does not fail and the pipeline continues. When an assessment fails, both the step and stage should be marked as failed. The pipeline should stop and also marked as failed. Currently this does not happen.

          Here is the stage:
          {code:java}
          stage('Assess') {
          steps {
          echo '=========== ^^^^^^^^^^^^ Assessing images...'
          script {
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdApi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          assessContainerImage failOnPluginError: true,
          imageId: "${env.imageIdUi}",
          thresholdRules: [totalVulnerabilities(action: 'Fail', threshold: '1')],
          nameRules: []
          }
          }
          }
          {code}

          And the resulting pipeline run:
           !pipeline-screenshot-1.png|thumbnail!

            rapid7 Rapid7 User
            jwhitby Jonathan Whitby
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: