• Type: Improvement
• Resolution: Unresolved
• Priority: Major
• Component/s: ldapemail-plugin
• Labels:

  None

1. ldapemail.patch

   3 kB

   2010-08-16 14:13

[JENKINS-6550] add flexiblity to LDAP search attribute, instead of just attribute=username, complete filter can be defined.

buesing created issue - 2010-05-17 20:56

buesing made changes - 2010-05-17 21:31

Issue Type

Original: Bug [ 1 ]

New: Improvement [ 4 ]

buesing made changes - 2010-05-18 04:56

Description

Original: LDAP Email Plugin requires the search attribute must be formatted to 'attribute=value'. I would like more attitude in for selection of LDAP search attribute. Example search attribute : (&(ID=%s)(cn=prefix*)) The 'LdapMailAddressResolver' requires one simple change to support this. Instead of "search attribute" being the attribute, it is an LDAP filter with %s entered for where userName is to be inserted.     private String performSearch(DirContext ctx, String userName) throws NamingException {         String emailAddress = null;         SearchControls controls = new SearchControls();         controls.setSearchScope(SearchControls.SUBTREE_SCOPE);         //String filter = String.format("%s=%s", configuration.getSearchAttribute(), userName);         String filter = String.format(configuration.getSearchAttribute(), userName);

New: LDAP Email Plugin requires the search attribute must be formatted to 'attribute=value'. I would like more options for selection of LDAP search attribute. Example search attribute : (&(ID=%s)(cn=prefix*)) The 'LdapMailAddressResolver' requires one simple change to support this. Instead of "search attribute" being the attribute, it is an LDAP filter with %s entered for where userName is to be inserted.     private String performSearch(DirContext ctx, String userName) throws NamingException {         String emailAddress = null;         SearchControls controls = new SearchControls();         controls.setSearchScope(SearchControls.SUBTREE_SCOPE);         //String filter = String.format("%s=%s", configuration.getSearchAttribute(), userName);         String filter = String.format(configuration.getSearchAttribute(), userName);

Collapse comment: ziraldo added a comment - 2010-08-16 14:13

ziraldo added a comment - 2010-08-16 14:13

I agree this is a much more flexible method of performing the search but I suggest changing the filter to a replaceAll so that we can use multiple matches of userName.

We would like to use a search attribute like (|(cn=%s)(uid=%s)), where the userName could match the cn or the uid.
I have attached a patch file to make this change.

Expand comment: ziraldo added a comment - 2010-08-16 14:13

ziraldo added a comment - 2010-08-16 14:13 I agree this is a much more flexible method of performing the search but I suggest changing the filter to a replaceAll so that we can use multiple matches of userName. We would like to use a search attribute like (|(cn=%s)(uid=%s)), where the userName could match the cn or the uid. I have attached a patch file to make this change.

ziraldo made changes - 2010-08-16 14:13

Attachment

New: ldapemail.patch [ 19666 ]

R. Tyler Croy made changes - 2016-07-25 23:49

Workflow

Original: JNJira [ 136645 ]

New: JNJira + In-Review [ 174534 ]