Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65862

Analyze / fix Subversion / pipeline ASM compatibility issue

    XMLWordPrintable

Details

    • 2.14.4

    Description

      as per https://github.com/jenkinsci/subversion-plugin/pull/254#issuecomment-858288074 reported by basil

      There looks like there is a regression (in waiting?) in the Subversion plugin against Pipeline and Jenkins core. (and potentially the other plugins in which Digester2 was removed.

      Attachments

        Activity

          teilo James Nord created issue -
          teilo James Nord made changes -
          Field Original Value New Value
          Summary Subversion / pipeline ASM compatability issue Analyze / fix Subversion / pipeline ASM compatibility issue
          teilo James Nord made changes -
          Assignee James Nord [ teilo ]
          teilo James Nord made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          teilo James Nord made changes -
          Assignee James Nord [ teilo ] Foundation Team [ foundation_test_security_members ]
          carroll Carroll Chiou made changes -
          Assignee Foundation Team [ foundation_test_security_members ] Carroll Chiou [ carroll ]
          basil Basil Crow added a comment -

          Since the problematic frames in the stack trace originate with Stapler, the impact of the regression should be limited to JenkinsRule-based tests only, not production (based on the reasoning James and I agreed on in the mailing list thread). Several of the Pipeline plugins depend on Subversion in their tests, though, and the BOM runs PCT on those Pipeline plugins, so we need to find some way to get these tests working again before we start a new BOM line for the LTS release after 2.289.

          basil Basil Crow added a comment - Since the problematic frames in the stack trace originate with Stapler, the impact of the regression should be limited to JenkinsRule -based tests only, not production (based on the reasoning James and I agreed on in the mailing list thread). Several of the Pipeline plugins depend on Subversion in their tests, though, and the BOM runs PCT on those Pipeline plugins, so we need to find some way to get these tests working again before we start a new BOM line for the LTS release after 2.289.
          carroll Carroll Chiou added a comment -

          basil I was able to confirm this manually. I attempted to reproduce the failing test with subversion 2.14.0, 2.14.1, and then a SNAPSHOT with asm excluded from Subversion and I still got the exact same behavior in all three tries.

          carroll Carroll Chiou added a comment - basil I was able to confirm this manually. I attempted to reproduce the failing test with subversion 2.14.0, 2.14.1, and then a SNAPSHOT with asm excluded from Subversion and I still got the exact same behavior in all three tries.
          basil Basil Crow added a comment -

          That's great news! So I think the main action item from my perspective is to get the tests for any plugin that depends on the Subversion plugin working again, especially if those tests are run as part of the BOM's PCT matrix. So far, I see that such tests are present in workflow-multibranch, workflow-cps-global-lib, and workflow-scm-step.

          basil Basil Crow added a comment - That's great news! So I think the main action item from my perspective is to get the tests for any plugin that depends on the Subversion plugin working again, especially if those tests are run as part of the BOM's PCT matrix. So far, I see that such tests are present in workflow-multibranch , workflow-cps-global-lib , and workflow-scm-step .
          olamy Olivier Lamy added a comment -

          for the record, the issue do not happen on real Jenkins instance but only for some unit tests. (for what I have been able to test subversion plugin)

          olamy Olivier Lamy added a comment - for the record, the issue do not happen on real Jenkins instance but only for some unit tests. (for what I have been able to test subversion plugin)
          foundation_security_members CloudBees Foundation Security made changes -
          Issue Type Bug [ 1 ] Task [ 3 ]
          foundation_security_members CloudBees Foundation Security made changes -
          Comment [ I've changed the type from Bug to Task as it seems there is no real regression in the production environment, but in test one. ]
          mramonleon Ramon Leon added a comment -

          I've changed the type from Bug to Task as it seems there is no real regression in the production environment, but in test one.

          mramonleon Ramon Leon added a comment - I've changed the type from Bug to Task as it seems there is no real regression in the production environment, but in test one.
          basil Basil Crow made changes -
          Remote Link This issue links to "jenkinsci/subversion-plugin#257 (Web Link)" [ 26780 ]
          carroll Carroll Chiou added a comment - digester has been removed in https://github.com/jenkinsci/subversion-plugin/pull/259
          carroll Carroll Chiou made changes -
          Remote Link This issue links to "https://github.com/jenkinsci/subversion-plugin/pull/259 (Web Link)" [ 26785 ]
          carroll Carroll Chiou made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Fixed but Unreleased [ 10203 ]
          carroll Carroll Chiou made changes -
          Released As 2.14.4
          Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
          carroll Carroll Chiou added a comment -

          Technically not completed until workflow-scm-step takes in the new subversion

          carroll Carroll Chiou added a comment - Technically not completed until workflow-scm-step takes in the new subversion
          carroll Carroll Chiou made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          carroll Carroll Chiou made changes -
          Released As 2.14.4 2.14
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Fixed but Unreleased [ 10203 ]
          carroll Carroll Chiou made changes -
          Released As 2.14 2.13
          Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
          carroll Carroll Chiou made changes -
          Released As 2.13 2.14.4

          People

            carroll Carroll Chiou
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: