Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65935

GitHub plugin invalid issue forwarding

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If you close an issue or pull request via a commit message on GitHub (seeĀ GitHub linking issues for a full list of messages supported), the link created used at the "Changes" tab invalid.
      It uses the following pattern: https://github.com/<org|user>/<repo>/issues/<issue id>/find
      The appended /find is out of place and will lead to a 404 on GitHub, removing it makes the link valid again.
      I attached a screenshot, clicking on "Closes #..." will lead to the invalid URL described above. Making it valid requires removing the /find at the end.

        Attachments

          Activity

          jthomas Jonathan created issue -
          jthomas Jonathan made changes -
          Field Original Value New Value
          Labels github-plugin plugin core github-plugin plugin
          Hide
          kon Kalle Niemitalo added a comment -

          The /find suffix seems to come from GithubLinkAnnotator.java, where it has been since 2009. If it is removed, then GithubLinkAnnotatorTest.java should be updated as well.

          Show
          kon Kalle Niemitalo added a comment - The /find suffix seems to come from GithubLinkAnnotator.java , where it has been since 2009. If it is removed, then GithubLinkAnnotatorTest.java should be updated as well.
          Hide
          notmyfault Alex added a comment - - edited

          This may also be expanded to the keywords closing issues.

          Show
          notmyfault Alex added a comment - - edited This may also be expanded to the keywords closing issues .

            People

            Assignee:
            lanwen Kirill Merkushev
            Reporter:
            jthomas Jonathan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated: