• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Component/s: envinject-plugin
• Labels:

  None

[JENKINS-65976] [envinject] Use SecretPatterns API

Jesse Glick created issue - 2021-06-23 21:02

Jesse Glick made changes - 2021-06-23 21:02

Component/s		New: envinject-plugin [ 15893 ]
Component/s	Original: mask-passwords-plugin [ 15761 ]

Jesse Glick made changes - 2021-06-23 21:02

Description

Original: https://github.com/jenkinsci/mask-passwords-plugin/blob/99a72fc75b3fa28939e98b39c508654261cee283/src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsOutputStream.java#L46 should be switched to use the new API from https://github.com/jenkinsci/credentials-binding-plugin/pull/139.

New: https://github.com/jenkinsci/envinject-plugin/blob/f72ef372efdef8791a175f1c121e067c10da40a6/src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java#L197 should be switched to use the new API from https://github.com/jenkinsci/credentials-binding-plugin/pull/139.

Collapse comment: Ian Williams added a comment - 2021-06-23 22:46

Ian Williams added a comment - 2021-06-23 22:46

ptierno might help to have plugin name in title so they are not all the same on a summary page, ie: "Use SecretPatterns API in envinject-plugin". Thought you accidentally hit the button 5x!

Expand comment: Ian Williams added a comment - 2021-06-23 22:46

Ian Williams added a comment - 2021-06-23 22:46 ptierno might help to have plugin name in title so they are not all the same on a summary page, ie: "Use SecretPatterns API in envinject-plugin". Thought you accidentally hit the button 5x!

Jesse Glick made changes - 2021-06-24 17:01

Summary

Original: Use SecretPatterns API

New: [envinject] Use SecretPatterns API