Hello,
This issue may duplicate JENKINS-45856 and is related to JENKINS-66169.
In our company we use legacy perforce plugin, which had support for wildcards in polling filters. A following view filer definition:
//depot/subdirectory-//.../*.txt
filters out all *.txt files as irrelevant changes (that do not trigger build in jenkins).
If changelist consists of only "//depot/subdirectory/docs/readme.txt" file, it would not trigger build.
Currently, p4 plugin only supports providing full file paths in negative filters (that start with "-").
Is it possible to include support for wildcards in polling filters?
I have attached proposed solution, however I don't know how complete it is and if it collides with JENKINS-45856 or not.
- duplicates
-
JENKINS-45856 support view Mask filters with wildcards
-
- In Progress
-
[JENKINS-66195] Add support for using wildcards in polling filters
Daniel Jeznach
created issue -
Daniel Jeznach
made changes -
| Description |
Original:
Hello,
This issue may duplicate [#JENKINS-45856] and is related to [# In our company we use legacy perforce plugin, which had support for wildcards in polling filters. A following view filer definition: {{//depot/subdirectory}}{{-//.../*.txt}} filters out all *.txt files as irrelevant changes (that do not trigger build in jenkins). If changelist consists of only "//depot/subdirectory/docs/readme.txt" file, it would not trigger build. Currently, p4 plugin only supports providing full file paths in negative filters (that start with "-"). Is it possible to include support for wildcards in polling filters? I have attached proposed solution, however I don't know how complete it is and if it collides with [#JENKINS-45856] or not. |
New:
Hello,
This issue may duplicate [JENKINS-45856|https://issues.jenkins.io/browse/JENKINS-45856] and is related to [ In our company we use legacy perforce plugin, which had support for wildcards in polling filters. A following view filer definition: {{//depot/subdirectory}}{{-//.../*.txt}} filters out all *.txt files as irrelevant changes (that do not trigger build in jenkins). If changelist consists of only "//depot/subdirectory/docs/readme.txt" file, it would not trigger build. Currently, p4 plugin only supports providing full file paths in negative filters (that start with "-"). Is it possible to include support for wildcards in polling filters? I have attached proposed solution, however I don't know how complete it is and if it collides with [JENKINS-45856|https://issues.jenkins.io/browse/JENKINS-45856] or not. |
Karl Wirth
made changes -
| Link | New: This issue duplicates JENKINS-45856 [ JENKINS-45856 ] |
Karl Wirth
made changes -
| Priority | Original: Minor [ 4 ] | New: Major [ 3 ] |
Karl Wirth
made changes -
| Labels | Original: filter polling | New: P4_A P4_VERIFY filter polling |
Daniel Jeznach
made changes -
| Attachment | Original: p4-viewfilter.diff [ 55236 ] |
Daniel Jeznach
made changes -
| Attachment | New: p4-viewfilter.diff [ 55261 ] |
Daniel Jeznach
added a comment - I'm attaching something more, than just diff to this ticket. I am using custom version of p4-plugin on my jenkinses with this implementation:
https://github.com/nephre/p4-plugin/tree/polling_filters_with_wildcard
Daniel Jeznach
added a comment - I'm attaching something more, than just diff to this ticket. I am using custom version of p4-plugin on my jenkinses with this implementation:
https://github.com/nephre/p4-plugin/tree/polling_filters_with_wildcard
Hi daniel_jeznach_img - Thank you. I agree it duplicates the other issue but I will keep this one open so the developers can see the suggested code change. I am also marking it as P4_A so they will review it during the next sprint planning session.