Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66306

Prepare OpenStack Cloud for core Guava upgrade

    • 2.59

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      Guava's cache

      In particular, this plugin has been identified as using the com.google.common.cache.Cache#get(K key) API, which has been removed between Guava 11.0.1 and latest. The removal took place in Guava 12.0.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to Caffeine via the Jenkins Caffeine API plugin.

      For the most part, the migration is a trivial matter of replacing imports of com.google.common.cache.Cache with imports of com.github.benmanes.caffeine.cache.Cache and imports of com.google.common.cache.CacheBuilder with imports of com.github.benmanes.caffeine.cache.Caffeine. For examples of how to do this, see these existing PRs:

      Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)

      In particular, this plugin has been identified as using the Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback) method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to rewrite this code to rewrite this code to use Futures#addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback, Executor executor), which is present in both Guava versions.

          [JENKINS-66306] Prepare OpenStack Cloud for core Guava upgrade

          Basil Crow created issue -
          Basil Crow made changes -
          Description Original: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          In particular, this plugin has been identified as using the {{com.google.common.cache.Cache#get(K key)}} API, which has been removed between Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/cache/Cache.html] and [latest|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/cache/Cache.html]. The removal took place in Guava 12.0.

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to [Caffeine|https://github.com/ben-manes/caffeine] via the Jenkins [Caffeine API|https://plugins.jenkins.io/caffeine-api/] plugin.

          For the most part, the migration is a trivial matter of replacing imports of {{com.google.common.cache.Cache}} with imports of {{com.github.benmanes.caffeine.cache.Cache}} and imports of {{com.google.common.cache.CacheBuilder}} with imports of {{com.github.benmanes.caffeine.cache.Caffeine}}. For examples of how to do this, see these existing PRs:

          * [jenkinsci/active-directory-plugin#109|https://github.com/jenkinsci/active-directory-plugin/pull/109]
          * [jenkinsci/azure-ad-plugin#125|https://github.com/jenkinsci/azure-ad-plugin/pull/125]
          * [jenkinsci/configuration-as-code-plugin#1596|https://github.com/jenkinsci/configuration-as-code-plugin/pull/1596]
          * [jenkinsci/kubernetes-plugin#991|https://github.com/jenkinsci/kubernetes-plugin/pull/991]
          * [jenkinsci/lockable-resources-plugin#242|https://github.com/jenkinsci/lockable-resources-plugin/pull/242]
          * [jenkinsci/role-strategy-plugin#150|https://github.com/jenkinsci/role-strategy-plugin/pull/150]
          New: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          h3. Guava's cache

          In particular, this plugin has been identified as using the {{com.google.common.cache.Cache#get(K key)}} API, which has been removed between Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/cache/Cache.html] and [latest|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/cache/Cache.html]. The removal took place in Guava 12.0.

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to [Caffeine|https://github.com/ben-manes/caffeine] via the Jenkins [Caffeine API|https://plugins.jenkins.io/caffeine-api/] plugin.

          For the most part, the migration is a trivial matter of replacing imports of {{com.google.common.cache.Cache}} with imports of {{com.github.benmanes.caffeine.cache.Cache}} and imports of {{com.google.common.cache.CacheBuilder}} with imports of {{com.github.benmanes.caffeine.cache.Caffeine}}. For examples of how to do this, see these existing PRs:

          * [jenkinsci/active-directory-plugin#109|https://github.com/jenkinsci/active-directory-plugin/pull/109]
          * [jenkinsci/azure-ad-plugin#125|https://github.com/jenkinsci/azure-ad-plugin/pull/125]
          * [jenkinsci/configuration-as-code-plugin#1596|https://github.com/jenkinsci/configuration-as-code-plugin/pull/1596]
          * [jenkinsci/kubernetes-plugin#991|https://github.com/jenkinsci/kubernetes-plugin/pull/991]
          * [jenkinsci/lockable-resources-plugin#242|https://github.com/jenkinsci/lockable-resources-plugin/pull/242]
          * [jenkinsci/role-strategy-plugin#150|https://github.com/jenkinsci/role-strategy-plugin/pull/150]

          h3. {{Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)}}

          In particular, this plugin has been identified as using the {{Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/util/concurrent/Futures.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/util/concurrent/Futures.html].

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to rewrite this code to rewrite this code to use {{Futures#addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback, Executor executor)}}, which is present in both Guava versions.
          Oliver Gondža made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oliver Gondža made changes -
          Released As New: 2.59
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Basil Crow made changes -
          Labels New: JEP-233
          Basil Crow made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            olivergondza Oliver Gondža
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: