-
Improvement
-
Resolution: Fixed
-
Major
See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.
Objects#firstNonNull
In particular, this plugin has been identified as using the com.google.common.base.Objects#firstNonNull method, which existed in Guava 11.0.1 but was removed in later versions.
To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#firstNonNull and rewrite the code to use the native functionality provided by the Java Platform.
For an example of how to do this, see:
Hasher#putString(CharSequence charSequence)
In particular, this plugin has been identified as using the com.google.common.hash.Hasher#putString(CharSequence charSequence) method, which existed in Guava 11.0.1 but was removed in later versions.
To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate to putString(CharSequence charSequence, Charset charset), which exists in both Guava versions.
[JENKINS-66317] Prepare GitHub for core Guava upgrade
Basil Crow
created issue -
Basil Crow
made changes -
| Assignee | Original: Kirill Merkushev [ lanwen ] | New: Kanstantsin Shautsou [ integer ] |
Basil Crow
made changes -
| Description |
Original:
See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.
In particular, this plugin has been identified as using the {{com.google.common.base.Objects#firstNonNull}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/base/Objects.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/base/Objects.html]. To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from {{Objects#firstNonNull}} and rewrite the code to use the native functionality provided by the Java Platform. For an example of how to do this, see: * [jenkinsci/gearman-plugin#14|https://github.com/jenkinsci/gearman-plugin/pull/14] |
New:
See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.
h3. {{Objects#firstNonNull}} In particular, this plugin has been identified as using the {{com.google.common.base.Objects#firstNonNull}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/base/Objects.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/base/Objects.html]. To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from {{Objects#firstNonNull}} and rewrite the code to use the native functionality provided by the Java Platform. For an example of how to do this, see: * [jenkinsci/gearman-plugin#14|https://github.com/jenkinsci/gearman-plugin/pull/14] h3. {{Hasher#putString(CharSequence charSequence)}} In particular, this plugin has been identified as using the {{com.google.common.hash.Hasher#putString(CharSequence charSequence)}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/hash/Hasher.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/hash/Hasher.html]. To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate to {{putString(CharSequence charSequence, Charset charset)}}, which exists in both Guava versions. |
| Assignee | Original: Kanstantsin Shautsou [ integer ] | New: Tim Jacomb [ timja ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
| Remote Link | New: This issue links to "https://github.com/jenkinsci/github-plugin/pull/252 (Web Link)" [ 26851 ] |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |
Basil Crow
made changes -
| Resolution | Original: Fixed [ 1 ] | |
| Status | Original: Resolved [ 5 ] | New: Reopened [ 4 ] |
Unfortunately this will need jenkinsci/github-plugin#254 as well I think.