Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66321

Prepare extreme-feedback for core Guava upgrade

XMLWordPrintable

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      toStringHelper

      In particular, this plugin has been identified as using the com.google.common.base.Objects#toStringHelper method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#toStringHelper and rewrite the code to use the native functionality provided by the Java Platform. Another option is to use Apache Commons Lang 2.4 (which is bundled in Jenkins core) and its org.apache.commons.lang.builder.ToStringBuilder API.

      Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)

      In particular, this plugin has been identified as using the Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback) method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to rewrite this code to rewrite this code to use Futures#addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback, Executor executor), which is present in both Guava versions.

          [JENKINS-66321] Prepare extreme-feedback for core Guava upgrade

          Basil Crow created issue -
          Basil Crow made changes -
          Description Original: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          In particular, this plugin has been identified as using the {{com.google.common.base.Objects#toStringHelper}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/base/Objects.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/base/Objects.html].

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from {{Objects#toStringHelper}} and rewrite the code to use the native functionality provided by the Java Platform. Another option is to use Apache Commons Lang 2.4 (which is bundled in Jenkins core) and its [{{org.apache.commons.lang.builder.ToStringBuilder}}|https://www.oschina.net/uploads/doc/commons-lang-2.4/org/apache/commons/lang/builder/ToStringBuilder.html] API.
          		New: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          h3. {{toStringHelper}}

          In particular, this plugin has been identified as using the {{com.google.common.base.Objects#toStringHelper}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/base/Objects.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/base/Objects.html].

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from {{Objects#toStringHelper}} and rewrite the code to use the native functionality provided by the Java Platform. Another option is to use Apache Commons Lang 2.4 (which is bundled in Jenkins core) and its [{{org.apache.commons.lang.builder.ToStringBuilder}}|https://www.oschina.net/uploads/doc/commons-lang-2.4/org/apache/commons/lang/builder/ToStringBuilder.html] API.

          h3. {{Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)}}

          In particular, this plugin has been identified as using the {{Futures#addCallback(addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback)}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/util/concurrent/Futures.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/util/concurrent/Futures.html].

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to rewrite this code to rewrite this code to use {{Futures#addCallback(ListenableFuture<V> future, FutureCallback<? super V> callback, Executor executor)}}, which is present in both Guava versions.
          Basil Crow made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Basil Crow made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Basil Crow made changes -
          Remote Link New: This issue links to "jenkinsci/extreme-feedback-plugin#8 (Web Link)" [ 26882 ]

          Basil Crow added a comment -

          emanuelez, would you be able to take a look at the PR I opened?

          Basil Crow added a comment - emanuelez , would you be able to take a look at the PR I opened ?
          Basil Crow made changes -
          Assignee Original: emanuelez [ emanuelez ] New: Basil Crow [ basil ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Basil Crow made changes -
          Labels New: JEP-233

          Basil Crow added a comment -

          Closing as "Won't Fix" because this plugin is now deprecated.

          Basil Crow added a comment - Closing as "Won't Fix" because this plugin is now deprecated.
          Basil Crow made changes -
          Resolution Original: Fixed [ 1 ] New: Won't Fix [ 2 ]
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]

            basil Basil Crow
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: