• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: github-branch-source-plugin
• Labels:

  None

1. 

   Screenshot 2021-09-20 113316.png

   19 kB

   2021-09-20 08:34

[JENKINS-66675] Disable masking of usernames for GitHub App secret

Iegor created issue - 2021-09-20 08:35

Iegor made changes - 2021-09-20 08:35

Description

Original: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.|https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]   As "App ID" is a number, it masks all such numbers in the console output.

New: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.|https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]   As "App ID" is a number, it masks all such numbers in the console output.

Iegor made changes - 2021-09-20 08:35

Attachment

New: Screenshot 2021-09-20 113316-1.png [ 56323 ]

Iegor made changes - 2021-09-20 08:36

Description

Original: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.|https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]   As "App ID" is a number, it masks all such numbers in the console output.

New: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.|https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]   As "App ID" is a number, it masks all such numbers in the console output. !Screenshot 2021-09-20 113316.png|width=617,height=92!

Iegor made changes - 2021-09-20 08:36

Attachment

Original: Screenshot 2021-09-20 113316-1.png [ 56323 ]

Iegor made changes - 2021-09-20 08:36

Description

Original: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.|https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]   As "App ID" is a number, it masks all such numbers in the console output. !Screenshot 2021-09-20 113316.png|width=617,height=92!

New: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type.   The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline. |https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]As "App ID" is a number, it masks all such numbers in the console output: !Screenshot 2021-09-20 113316.png|width=617,height=92!

Iegor made changes - 2021-09-20 08:37

Description

Original: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type.   The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline. |https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline]As "App ID" is a number, it masks all such numbers in the console output: !Screenshot 2021-09-20 113316.png|width=617,height=92!

New: The issue is the same/similar to JENKINS-44860 with masking "App ID" (which treats as username) of "GitHub App" type credentials. The issue was solved for "Username Password" credentials by adding "_Treat username as secret_" which is absent for "GitHub App" credentials type. The following doc was used to get App ID and token: [https://www.jenkins.io/blog/2020/04/16/github-app-authentication/#how-do-i-get-an-api-token-in-my-pipeline.     As "App ID" is a number, it masks all such numbers in the console output: !Screenshot 2021-09-20 113316.png|width=617,height=92!

Collapse comment: Alberto Gallardo added a comment - 2023-12-01 16:39

Alberto Gallardo added a comment - 2023-12-01 16:39

I completely second this feature request, specially after having confronted https://issues.jenkins.io/browse/JENKINS-72412

Expand comment: Alberto Gallardo added a comment - 2023-12-01 16:39

Alberto Gallardo added a comment - 2023-12-01 16:39 I completely second this feature request, specially after having confronted https://issues.jenkins.io/browse/JENKINS-72412

Alberto Gallardo made changes - 2023-12-01 18:48

Component/s

New: github-branch-source-plugin [ 20858 ]

Collapse comment: Alberto Gallardo added a comment - 2023-12-01 18:49

Alberto Gallardo added a comment - 2023-12-01 18:49

This should be solved in github-branch-source-plugin, as suggested here: https://github.com/jenkinsci/credentials-binding-plugin/pull/284#issuecomment-1836522834

Expand comment: Alberto Gallardo added a comment - 2023-12-01 18:49

Alberto Gallardo added a comment - 2023-12-01 18:49 This should be solved in github-branch-source-plugin, as suggested here: https://github.com/jenkinsci/credentials-binding-plugin/pull/284#issuecomment-1836522834

Load more newer events