• Type: Task
• Resolution: Fixed
• Priority: Minor
• Component/s: core
• Labels:

  • newbie-friendly

[JENKINS-66723] Un-inlining ListView/configure-entries.jelly

Wadeck Follonier created issue - 2021-09-24 15:00

Wadeck Follonier made changes - 2021-09-24 15:01

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [control.jelly#L40-L167|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/BuildTimelineWidget/control.jelly#L40-L167] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [ListView/configure-entries.jelly#L74-L85|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/ListView/configure-entries.jelly#L74-L85] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }}

Wadeck Follonier made changes - 2021-09-24 18:02

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [ListView/configure-entries.jelly#L74-L85|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/ListView/configure-entries.jelly#L74-L85] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }}

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [ListView/configure-entries.jelly#L74-L85|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/ListView/configure-entries.jelly#L74-L85] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }}

Wadeck Follonier made changes - 2021-09-24 18:06

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [ListView/configure-entries.jelly#L74-L85|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/ListView/configure-entries.jelly#L74-L85] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }}

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [ListView/configure-entries.jelly#L74-L85|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/ListView/configure-entries.jelly#L74-L85] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes=...}}

Dmitry Platonov made changes - 2021-10-04 21:38

Assignee

New: Dmitry Platonov [ pldi23 ]

Collapse comment: Dmitry Platonov added a comment - 2021-10-05 05:28

Dmitry Platonov added a comment - 2021-10-05 05:28

PR link: https://github.com/jenkinsci/jenkins/pull/5786

Expand comment: Dmitry Platonov added a comment - 2021-10-05 05:28

Dmitry Platonov added a comment - 2021-10-05 05:28 PR link: https://github.com/jenkinsci/jenkins/pull/5786

Wadeck Follonier made changes - 2021-10-05 06:41

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Wadeck Follonier made changes - 2021-10-05 06:41

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Wadeck Follonier made changes - 2021-10-23 12:04

Released As		New: 2.316
Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Resolved [ 5 ]

Basil Crow made changes - 2024-10-01 23:50

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]

Load more newer events