• Type: Task
• Resolution: Fixed
• Priority: Minor
• Component/s: core
• Labels:

  • newbie-friendly

[JENKINS-66728] Un-inlining UpdateCenter/index.jelly

Wadeck Follonier created issue - 2021-09-24 18:00

Wadeck Follonier made changes - 2021-09-24 18:02

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tag [BuildTimelineWidget/control.jelly#L40-L167|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/BuildTimelineWidget/control.jelly#L40-L167] to its own file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tags [UpdateCenter/index.jelly#L35-L42|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L35-L42] and [UpdateCenter/index.jelly#L45-L77|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L45-L77] to a single separate file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

Wadeck Follonier made changes - 2021-09-24 18:02

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy. *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tags [UpdateCenter/index.jelly#L35-L42|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L35-L42] and [UpdateCenter/index.jelly#L45-L77|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L45-L77] to a single separate file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tags [UpdateCenter/index.jelly#L35-L42|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L35-L42] and [UpdateCenter/index.jelly#L45-L77|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L45-L77] to a single separate file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

Wadeck Follonier made changes - 2021-09-24 18:06

Description

Original: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tags [UpdateCenter/index.jelly#L35-L42|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L35-L42] and [UpdateCenter/index.jelly#L45-L77|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L45-L77] to a single separate file. To inject separate file into Jelly, you can use {{<st:adjunct includes= ... }} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

New: _(For details, please refer to the GDoc link in the Epic description)_ *Difficulty*: easy *Skill requirement*: JavaScript (basic), Jelly (basic) Move the script tags [UpdateCenter/index.jelly#L35-L42|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L35-L42] and [UpdateCenter/index.jelly#L45-L77|https://github.com/jenkinsci/jenkins/blob/726a0e3ec4c6d8ac8985144f20aa4b330dc9429b/core/src/main/resources/hudson/model/UpdateCenter/index.jelly#L45-L77] to a single separate file. To inject separate file into Jelly, you can use {{<st:adjunct includes=...}} One variable injected, you will need to use advice from https://www.jenkins.io/doc/developer/security/xss-prevention/#passing-values-to-javascript

megathaum made changes - 2021-10-02 08:52

Assignee

New: megathaum [ megathaum ]

Collapse comment: Kristóf Sz. added a comment - 2021-10-22 15:58

Kristóf Sz. added a comment - 2021-10-22 15:58

Hy! Do you think I can take on this task? I see its assigned, but I think there is no progress on it.

Also I'm new to jelly, but based on the linked docs, I cant see an injected variable. Did that line just remain from the copy-paste?

Expand comment: Kristóf Sz. added a comment - 2021-10-22 15:58

Kristóf Sz. added a comment - 2021-10-22 15:58 Hy! Do you think I can take on this task? I see its assigned, but I think there is no progress on it. Also I'm new to jelly, but based on the linked docs, I cant see an injected variable. Did that line just remain from the copy-paste?

megathaum made changes - 2021-10-22 16:18

Assignee

Original: megathaum [ megathaum ]

Collapse comment: megathaum added a comment - 2021-10-22 16:19

megathaum added a comment - 2021-10-22 16:19

Hi! Please take it. I've not yet started on this. I've unassigned it and will take up another one. Thanks!

Expand comment: megathaum added a comment - 2021-10-22 16:19

megathaum added a comment - 2021-10-22 16:19 Hi! Please take it. I've not yet started on this. I've unassigned it and will take up another one. Thanks!

Kristóf Sz. made changes - 2021-10-22 16:28

Assignee

New: Kristóf Sz. [ littletof ]

Collapse comment: Kristóf Sz. added a comment - 2021-10-22 16:28

Kristóf Sz. added a comment - 2021-10-22 16:28

Thanks!
Opened a PR: https://github.com/jenkinsci/jenkins/pull/5848

Expand comment: Kristóf Sz. added a comment - 2021-10-22 16:28

Kristóf Sz. added a comment - 2021-10-22 16:28 Thanks! Opened a PR:  https://github.com/jenkinsci/jenkins/pull/5848

Load more newer events