• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Blocker Blocker
    • htmlpublisher-plugin
    • None
    • Plugin version: 1.26
      Operating system: Windows 10

      The following change from 1.25 to 1.26 breaks my reports.

      I've prepared an example in htmlpublisher.zip.

      1. Extract the zip file
      2. Open the htmlpublisher-wrapper.html with chrome
      3. You will see something like this:
      4. Change in htmlpublisher-wrapper.html the line "iframe.src = encodeURIComponent(tab.getAttribute("value"));" to "
        iframe.src = tab.getAttribute("value");"
      5. The page works then as expected 

          [JENKINS-66897] encodeURIComponent breaks paths

          burn hard created issue -
          burn hard made changes -
          Description Original: The following change breaks from 1.25 to 1.26 breaks my reports.

          !image-2021-10-14-13-40-31-713.png!

          I've prepared an example in htmlpublisher.zip.
           # Extract the zip file
           # Open the htmlpublisher-wrapper.html with chrome
           # You will see something like this: !image-2021-10-14-13-53-38-495.png!
           # Change in htmlpublisher-wrapper.html the line "iframe.src = encodeURIComponent(tab.getAttribute("value"));" to "
          iframe.src = tab.getAttribute("value");" !image-2021-10-14-13-51-03-532.png!
           # The page works then as expected  !image-2021-10-14-13-53-03-565.png!
          New: The following change breaks from 1.25 to 1.26 breaks my reports.

          !image-2021-10-14-13-40-31-713.png!

          I've prepared an example in htmlpublisher.zip.
           # Extract the zip file
           # Open the htmlpublisher-wrapper.html with chrome
           # You will see something like this:
           # !image-2021-10-14-13-53-38-495.png!
           # Change in htmlpublisher-wrapper.html the line "iframe.src = encodeURIComponent(tab.getAttribute("value"));" to "
           iframe.src = tab.getAttribute("value");"
           # !image-2021-10-14-13-51-03-532.png!
           # The page works then as expected 
           # !image-2021-10-14-13-53-03-565.png!
          burn hard made changes -
          Description Original: The following change breaks from 1.25 to 1.26 breaks my reports.

          !image-2021-10-14-13-40-31-713.png!

          I've prepared an example in htmlpublisher.zip.
           # Extract the zip file
           # Open the htmlpublisher-wrapper.html with chrome
           # You will see something like this:
           # !image-2021-10-14-13-53-38-495.png!
           # Change in htmlpublisher-wrapper.html the line "iframe.src = encodeURIComponent(tab.getAttribute("value"));" to "
           iframe.src = tab.getAttribute("value");"
           # !image-2021-10-14-13-51-03-532.png!
           # The page works then as expected 
           # !image-2021-10-14-13-53-03-565.png!
          New: The following change from 1.25 to 1.26 breaks my reports.

          !image-2021-10-14-13-40-31-713.png!

          I've prepared an example in htmlpublisher.zip.
           # Extract the zip file
           # Open the htmlpublisher-wrapper.html with chrome
           # You will see something like this:
           # !image-2021-10-14-13-53-38-495.png!
           # Change in htmlpublisher-wrapper.html the line "iframe.src = encodeURIComponent(tab.getAttribute("value"));" to "
           iframe.src = tab.getAttribute("value");"
           # !image-2021-10-14-13-51-03-532.png!
           # The page works then as expected 
           # !image-2021-10-14-13-53-03-565.png!

          olamy Are you able to take a look? It looks like the change is encoding things which it shouldn't (slashes in this case) which is breaking files in directories.

          Richard Bywater added a comment - olamy  Are you able to take a look? It looks like the change is encoding things which it shouldn't (slashes in this case) which is breaking files in directories.

          burn hard added a comment -

          Are there any updates on this?

          burn hard added a comment - Are there any updates on this?
          Kalle Niemitalo made changes -
          Link New: This issue relates to JENKINS-65028 [ JENKINS-65028 ]

            r2b2_nz Richard Bywater
            b8erni burn hard
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: