Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67201

Replace innerHTML with innerText

XMLWordPrintable

      In https://github.com/jenkinsci/dashboard-view-plugin/blob/b945bace90a5e7b28656f5b254ec5e12d5956681/src/main/resources/hudson/plugins/view/dashboard/stats/StatSlaves/statagents.jelly#L12-L25 there are multiple calls to innerHTML, which are not necessary. A simple innerText is sufficient in this case and will be more safe as innerHTML is vulnerable to XSS. In this particular case it's not (yet) dangerous as the values passed are just integers.

          [JENKINS-67201] Replace innerHTML with innerText

          Wadeck Follonier created issue -
          Jenkins CERT Bot made changes -
          Labels Original: newbie-friendly New: jcabot:001 jcabot:002 newbie-friendly
          Tobias Gruetzmacher made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

            tgr Tobias Gruetzmacher
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: