-
Bug
-
Resolution: Fixed
-
Minor
https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72 is an attempt to deduplicate traces with object identities.
Unfortunately, this doesn't work with traces from UserRPCRequest, that include a counter:
Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at …
Another source for duplication is proxies:
at com.sun.proxy.$Proxy5.end(Unknown Source) at com.sun.proxy.$Proxy6.end(Unknown Source)
- links to
[JENKINS-67226] Deduplication of traces doesn't work for UserRPCRequest
Description |
Original:
[https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72] is an attempt to deduplicate traces with object identities.
Unfortunately, this doesn't work with traces from {{UserRPCRequest}}, that include a counter: {noformat} Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at …{noformat} |
New:
[https://github.com/jenkinsci/jenkins/blob/55c31c892c224b7bd12714ec1c20dbeae68defde/core/src/main/java/jenkins/telemetry/impl/SlaveToMasterFileCallableUsage.java#L72] is an attempt to deduplicate traces with object identities.
Unfortunately, this doesn't work with traces from {{UserRPCRequest}}, that include a counter: {noformat} Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](26) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](27) created at … Command UserRequest:UserRPCRequest:hudson.maven.MavenBuildProxy2.end[](28) created at …{noformat} Another source for duplication is proxies: {noformat} at com.sun.proxy.$Proxy5.end(Unknown Source) at com.sun.proxy.$Proxy6.end(Unknown Source) {noformat} |
Epic Link |
New:
|
Remote Link | New: This issue links to "jenkins #5957 (Web Link)" [ 27261 ] |
Assignee | New: Daniel Beck [ danielbeck ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Released As | New: 2.323 | |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Fixed but Unreleased [ 10203 ] |
And \r\n instead of \n, and line numbers in stack frames, and lambda names, and details of call sequences inside the JRE.
Since the data collector evidently does no deduplication of its own, perhaps none of this matters anyway. I am currently using